Add possibility to change default request params#1466
Open
k1rd3rf wants to merge 7 commits intoacacode:mainfrom
Open
Add possibility to change default request params#1466k1rd3rf wants to merge 7 commits intoacacode:mainfrom
k1rd3rf wants to merge 7 commits intoacacode:mainfrom
Conversation
Useful when overriding the http client, and you want to make sure the request params are set. Can be set to `""` in order to not make it optional.
🦋 Changeset detectedLatest commit: 6ffc807 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
bugbot run |
Collaborator
|
@codex review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when overriding the http client, and you want to make sure the request params are set.
Can be set to
""in order to not make it optional.Note
Introduce
defaultRequestParamsconfig/CLI flag to set the default request params in generated APIs, applied in templates and covered by tests.default-request-paramsCLI arg and plumb togenerateApiasdefaultRequestParams.CodeGenConfig(defaultRequestParams = "{}").config.defaultRequestParamsfor request config arg default intemplates/default/procedure-call.ejsandtemplates/modular/procedure-call.ejs.GenerateApiConfiguration.configwithdefaultRequestParams: string.tests/spec/defaultRequestParams/*with snapshots for basic, modular, and empty default cases.Written by Cursor Bugbot for commit 8d62600. This will update automatically on new commits. Configure here.