Made loading mathjax, plotly and mermaid optional for each page #3237
+17
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance of the theme could be greatly enhanced if support for MathJax, Plotly and Mermaid was enabled only when necessary. A simple way to do this would be to do in
_includes\footer\custom.html
{% if page.mathjax %} <script defer src="https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es6"></script> <script defer src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js" id="MathJax-script"></script> {% endif %}
and set
mathjax: true
in the defaults of_config.yml
.If a certain page does not require mathjax then the user could set
mathjax: false
in the YAML header of the page, thus saving a lot of JS runtime! All of this is also applicable forplotly
andmermaid
.Personally, I'm setting by default
mathjax: false
. But this may complicate using the theme for new users.