Open
Conversation
…wayAttachment` to be created
apply a `cfn-lint` suggestion: ``` W1020 Fn::Sub isn't needed because there are no variables at Resources/WEBLaunchTemplate/Properties/LaunchTemplateData/UserData/Fn::Base64/Fn::Sub ```
seomago
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR proposes a fix to an issue that was reported in slack:
https://techstudyslack.slack.com/archives/C010173PTGU/p1693031828964669
The issue was encountered during deployment of
ALBSTICKINESS.yamlstack, with the following error message:the
ALBresource in the stack fails to deploy, because theInternetGatewayAttachmentresource wasn't being created before the ALB resource.Proposed fix to issue
The proposed fix to this issue is to add a
DependsOn: InternetGatewayAttachmentattribute to theALBresource to addInternetGatewayAttachmentresource as a dependency forALBresource.N.B:
Also included a minor improvement to stack template, suggested by
cfn-linttool, to remove the use of!Subintrinsic function fromUserDataattribute inWEBLaunchTemplateresource.