Skip to content

Commit aaf5e3b

Browse files
committed
refactor: Remove unused NutritionAdvisor agent
The NutritionAdvisor agent was superseded by AssistantAgent which is now bound to the Advisor interface. This cleanup removes the unused NutritionAdvisor class and updates all references to use AssistantAgent. Changes: - Delete app/Ai/Agents/NutritionAdvisor.php - Update HistoryFactory default agent to AssistantAgent - Update HistoryTest to expect AssistantAgent as default - Update ProcessAdvisorMessageActionTest to use AssistantAgent
1 parent 9fc8b92 commit aaf5e3b

File tree

4 files changed

+13
-230
lines changed

4 files changed

+13
-230
lines changed

app/Ai/Agents/NutritionAdvisor.php

Lines changed: 0 additions & 217 deletions
This file was deleted.

database/factories/HistoryFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function definition(): array
2929
'id' => (string) Str::uuid7(),
3030
'conversation_id' => Conversation::factory(),
3131
'user_id' => User::factory(),
32-
'agent' => \App\Ai\Agents\NutritionAdvisor::class,
32+
'agent' => \App\Ai\Agents\AssistantAgent::class,
3333
'role' => fake()->randomElement([MessageRole::User, MessageRole::Assistant]),
3434
'content' => fake()->paragraph(),
3535
'attachments' => [],

tests/Unit/Actions/ProcessAdvisorMessageActionTest.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
declare(strict_types=1);
44

55
use App\Actions\ProcessAdvisorMessageAction;
6-
use App\Ai\Agents\NutritionAdvisor;
6+
use App\Ai\Agents\AssistantAgent;
77
use App\Models\User;
88
use Laravel\Ai\Contracts\ConversationStore;
99

1010
it('creates new conversation when none exists', function (): void {
11-
NutritionAdvisor::fake(['Hello!']);
11+
AssistantAgent::fake(['Hello!']);
1212

1313
$conversationStore = mock(ConversationStore::class);
1414
$conversationStore
@@ -24,7 +24,7 @@
2424
->andReturn('conv-123');
2525

2626
$action = new ProcessAdvisorMessageAction(
27-
resolve(NutritionAdvisor::class),
27+
resolve(AssistantAgent::class),
2828
$conversationStore,
2929
);
3030

@@ -33,14 +33,14 @@
3333

3434
expect($result['response'])->toBe('Hello!');
3535
expect($result['conversation_id'])->toBe('conv-123');
36-
NutritionAdvisor::assertPrompted('Test message');
36+
AssistantAgent::assertPrompted('Test message');
3737
});
3838

3939
it('uses existing conversation when provided', function (): void {
40-
NutritionAdvisor::fake(['Continuing...']);
40+
AssistantAgent::fake(['Continuing...']);
4141

4242
$action = new ProcessAdvisorMessageAction(
43-
resolve(NutritionAdvisor::class),
43+
resolve(AssistantAgent::class),
4444
resolve(ConversationStore::class),
4545
);
4646

@@ -52,7 +52,7 @@
5252
});
5353

5454
it('reuses latest conversation when no id provided but exists', function (): void {
55-
NutritionAdvisor::fake(['Reusing!']);
55+
AssistantAgent::fake(['Reusing!']);
5656

5757
$conversationStore = mock(ConversationStore::class);
5858
$conversationStore
@@ -62,7 +62,7 @@
6262
->andReturn('latest-conv');
6363

6464
$action = new ProcessAdvisorMessageAction(
65-
resolve(NutritionAdvisor::class),
65+
resolve(AssistantAgent::class),
6666
$conversationStore,
6767
);
6868

@@ -82,7 +82,7 @@
8282
->andReturn('new-conv');
8383

8484
$action = new ProcessAdvisorMessageAction(
85-
resolve(NutritionAdvisor::class),
85+
resolve(AssistantAgent::class),
8686
$conversationStore,
8787
);
8888

tests/Unit/Models/HistoryTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
declare(strict_types=1);
44

5-
use App\Ai\Agents\NutritionAdvisor;
5+
use App\Ai\Agents\AssistantAgent;
66
use App\Models\Conversation;
77
use App\Models\History;
88
use App\Models\User;
@@ -73,10 +73,10 @@
7373
->and($history->meta)->toBeArray()->toHaveKey('key');
7474
});
7575

76-
it('defaults agent to NutritionAdvisor', function (): void {
76+
it('defaults agent to AssistantAgent', function (): void {
7777
$history = History::factory()->create();
7878

79-
expect($history->agent)->toBe(NutritionAdvisor::class);
79+
expect($history->agent)->toBe(AssistantAgent::class);
8080
});
8181

8282
it('can set custom agent', function (): void {

0 commit comments

Comments
 (0)