Fix LUD kernel syncthreads bug and clean up microbenchmark binaries #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix critical CUDA synchronization bug in lud_diagonal kernel where __syncthreads() was called inside conditional blocks. This caused undefined behavior as not all threads reached the barrier. Moved syncthreads outside the if-blocks so all threads participate. - Change GPU_Microbenchmark build to use mv instead of cp to avoid leaving duplicate binaries in source directories. - Add clean_GPU_Microbenchmark to the main clean target. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lud_diagonalkernel where__syncthreads()was called inside conditional blocks, causing undefined behaviormvinstead ofcpto avoid leaving duplicate binaries in source directoriesclean_GPU_Microbenchmarkto the main clean targetTest plan
🤖 Generated with Claude Code