WIP: Parallel SystemC Module#118
Draft
markfoodyburton wants to merge 6 commits intoaccellera-official:mainfrom
Draft
WIP: Parallel SystemC Module#118markfoodyburton wants to merge 6 commits intoaccellera-official:mainfrom
markfoodyburton wants to merge 6 commits intoaccellera-official:mainfrom
Conversation
Contributor
Author
|
Todo: wrap calls to b_transport/nb_transport etc such that they are called on the right simcontext. |
maehne
reviewed
May 12, 2025
Contributor
maehne
left a comment
There was a problem hiding this comment.
So far, PR looks good. As you you mention WIP in title, I would suggest that you mark it explicitly as draft in the PR's properties.
src/sysc/kernel/sc_event.h
Outdated
| sc_time time; | ||
|
|
||
| void stage_callback(const sc_core::sc_stage& stage) { | ||
| mutex.lock(); |
8c4a2e2 to
97c6717
Compare
…imcontext::init Signed-off-by: Mark Burton <mburton@quicinc.com>
Signed-off-by: Mark Burton <mburton@quicinc.com>
…d nb_transport thread safe, other tlm APIs are NOT handled Signed-off-by: Mark Burton <mburton@quicinc.com>
Signed-off-by: Mark Burton <mburton@quicinc.com>
97c6717 to
c2d4c18
Compare
Contributor
Author
|
Still an issue to do with prim_channels - created due to dynamic event creation after start of simulation, which generates a new 'name' - putting that into the name hierarchy is not thread safe, and causes things to go wrong if you run for long enough..... |
Contributor
Author
THANKS @maehne ! |
Signed-off-by: Mark Burton <mburton@quicinc.com>
5feda24 to
69f610b
Compare
Signed-off-by: Mark Burton <mburton@quicinc.com>
69f610b to
c60e62c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.