Advanced Ballistics - Take object size and trees into account for terrain roughness#10697
Merged
LinkIsGrim merged 2 commits intomasterfrom Feb 5, 2025
Merged
Advanced Ballistics - Take object size and trees into account for terrain roughness#10697LinkIsGrim merged 2 commits intomasterfrom
LinkIsGrim merged 2 commits intomasterfrom
Conversation
PabstMirror
reviewed
Jan 29, 2025
| private _volume = (_bb#1#0 - _bb#0#0) * (_bb#1#1 - _bb#0#1) * _height; | ||
|
|
||
| (_height > 0.3) && {_volume > 10} | ||
| } count (_windSource nearObjects ["Building", 50]); |
Contributor
There was a problem hiding this comment.
help[L-S13]: Undefined Var - _windSource
┌─ addons/advanced_ballistics/functions/fnc_initializeTerrainExtension.sqf:69:18
│
69 │ } count (_windSource nearObjects ["Building", 50]);
│ ^^^^^^^^^^^
LinkIsGrim
reviewed
Feb 3, 2025
Member
LinkIsGrim
left a comment
LinkIsGrim
left a comment
There was a problem hiding this comment.
LGTM but have to figure out the undefined var
LinkIsGrim
reviewed
Feb 5, 2025
addons/advanced_ballistics/functions/fnc_initializeTerrainExtension.sqf
Outdated
Show resolved
Hide resolved
LinkIsGrim
approved these changes
Feb 5, 2025
Member
|
Hopefully this doesn't blow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Refactor terrain roughness to:
Did not touch the extension, should work as before.
Results were compared with this table, not perfect but definitely better than before:
Source