Manpad - Add stinger locking by PabstMirror · Pull Request #10830 · acemod/ACE3

PabstMirror · 2025-03-29T18:07:07Z

stinger.mp4

addons/missile_manpad/XEH_postInit.sqf

TheCandianVendingMachine · 2025-04-04T00:19:26Z

addons/missile_manpad/functions/fnc_eachFrame.sqf

+private _lockFeedback = 0;
+if (isNull _lockCanidate) then {
+    // find any target within seeker range
+    private _potentialTargets = _source nearEntities ["Air", _seekerMaxRange];


flares won't be locked with this, idk if thats desired. it may make more sense to break out the target logic into its own function and call that

I was wondering if this should more closely just copy the ir_seeker code

i think it should; i'd want to break the logic into it's own function just because its a but unweidly and if it changes in the future it'd be a pain to update twice

addons/missile_manpad/XEH_postInit.sqf

Copilot

Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.

Files not reviewed (13)

addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp: Language not supported
addons/missile_manpad/CfgEventHandlers.hpp: Language not supported
addons/missile_manpad/CfgSounds.hpp: Language not supported
addons/missile_manpad/CfgWeapons.hpp: Language not supported
addons/missile_manpad/XEH_PREP.hpp: Language not supported
addons/missile_manpad/XEH_postInit.sqf: Language not supported
addons/missile_manpad/XEH_preInit.sqf: Language not supported
addons/missile_manpad/XEH_preStart.sqf: Language not supported
addons/missile_manpad/config.cpp: Language not supported
addons/missile_manpad/functions/fnc_eachFrame.sqf: Language not supported
addons/missile_manpad/functions/fnc_weaponChanged.sqf: Language not supported
addons/missile_manpad/script_component.hpp: Language not supported
addons/missileguidance/dev/mock_ammo.hpp: Language not supported

TheCandianVendingMachine · 2025-04-07T06:04:12Z

Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (13)

* **addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp**: Language not supported

* **addons/missile_manpad/CfgEventHandlers.hpp**: Language not supported

* **addons/missile_manpad/CfgSounds.hpp**: Language not supported

* **addons/missile_manpad/CfgWeapons.hpp**: Language not supported

* **addons/missile_manpad/XEH_PREP.hpp**: Language not supported

* **addons/missile_manpad/XEH_postInit.sqf**: Language not supported

* **addons/missile_manpad/XEH_preInit.sqf**: Language not supported

* **addons/missile_manpad/XEH_preStart.sqf**: Language not supported

* **addons/missile_manpad/config.cpp**: Language not supported

* **addons/missile_manpad/functions/fnc_eachFrame.sqf**: Language not supported

* **addons/missile_manpad/functions/fnc_weaponChanged.sqf**: Language not supported

* **addons/missile_manpad/script_component.hpp**: Language not supported

* **addons/missileguidance/dev/mock_ammo.hpp**: Language not supported

the fuck is the point of the bot if it doesn't support 99% of the files 😭

PabstMirror · 2025-04-09T05:33:39Z

prob do explicit config because CWR has a javelin (AA/blowpipe-like) that inherits from cup_stinger

TheCandianVendingMachine · 2025-04-09T23:18:04Z

note: this can be expanded to Sidewinder soon whenever this goes stable (https://feedback.bistudio.com/T190789)

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

addons/missile_manpad/functions/fnc_eachFrame.sqf

LinkIsGrim · 2025-06-22T19:29:22Z

addons/compat_cup_weapons/compat_cup_missileguidance/config.cpp

 #include "\z\ace\addons\missileguidance\script_missileBases.hpp"
 #include "CfgAmmo.hpp"
+
+class CfgWeapons { //todo


LinkIsGrim

Code LGTM, not tested and the the finer points of missileguidance go over my head.

TheCandianVendingMachine

After some thought, I think a common method to search for targets would benefit this. As is it works, but there are discrepancies between the actual seeker and this tracker

Manpad - Add stinger locking

7e357ad

PabstMirror added the kind/feature Release Notes: **ADDED:** label Mar 29, 2025

PabstMirror mentioned this pull request Mar 29, 2025

Missile Guidance - LOBL-only missiles exhibit LOAL behaviour #10808

Open

cleanup

0f608a8

TheCandianVendingMachine reviewed Apr 4, 2025

View reviewed changes

addons/missile_manpad/XEH_postInit.sqf Outdated Show resolved Hide resolved

TheCandianVendingMachine reviewed Apr 4, 2025

View reviewed changes

rautamiekka suggested changes Apr 4, 2025

View reviewed changes

addons/missile_manpad/XEH_postInit.sqf Outdated Show resolved Hide resolved

PabstMirror requested a review from Copilot April 4, 2025 17:13

Copilot AI reviewed Apr 4, 2025

View reviewed changes

PabstMirror and others added 6 commits April 25, 2025 18:33

Update addons/missile_manpad/XEH_postInit.sqf

84b4c4e

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

Merge branch 'master' into stinger

e455235

Added explicit enabled check

ec647ca

fx notes

416f953

Merge branch 'master' into stinger

89588d4

Update XEH_postInit.sqf

af3f5e9

rautamiekka suggested changes May 7, 2025

View reviewed changes

addons/missile_manpad/functions/fnc_eachFrame.sqf Outdated Show resolved Hide resolved

d

1e1ae4b

PabstMirror marked this pull request as ready for review May 25, 2025 15:35

PabstMirror added this to the 3.20.0 milestone Jun 22, 2025

LinkIsGrim reviewed Jun 22, 2025

View reviewed changes

LinkIsGrim approved these changes Jun 22, 2025

View reviewed changes

TheCandianVendingMachine requested changes Jun 22, 2025

View reviewed changes

PabstMirror modified the milestones: 3.20.0, Ongoing Jun 23, 2025

Merge branch 'master' into stinger

b292be6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manpad - Add stinger locking#10830

Manpad - Add stinger locking#10830
PabstMirror wants to merge 10 commits intomasterfrom
stinger

PabstMirror commented Mar 29, 2025

Uh oh!

Uh oh!

TheCandianVendingMachine Apr 4, 2025 •

edited

Loading

Uh oh!

PabstMirror Apr 4, 2025

Uh oh!

TheCandianVendingMachine Apr 7, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

TheCandianVendingMachine commented Apr 7, 2025

Uh oh!

PabstMirror commented Apr 9, 2025 •

edited

Loading

Uh oh!

TheCandianVendingMachine commented Apr 9, 2025

Uh oh!

Uh oh!

LinkIsGrim Jun 22, 2025

Uh oh!

LinkIsGrim left a comment

Uh oh!

TheCandianVendingMachine left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

PabstMirror commented Mar 29, 2025

Uh oh!

Uh oh!

TheCandianVendingMachine Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PabstMirror Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

TheCandianVendingMachine Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

TheCandianVendingMachine commented Apr 7, 2025

Uh oh!

PabstMirror commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheCandianVendingMachine commented Apr 9, 2025

Uh oh!

Uh oh!

LinkIsGrim Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

LinkIsGrim left a comment

Choose a reason for hiding this comment

Uh oh!

TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TheCandianVendingMachine Apr 4, 2025 •

edited

Loading

PabstMirror commented Apr 9, 2025 •

edited

Loading