Skip to content

Aircraft - Remove unused base classes#10955

Merged
PabstMirror merged 2 commits intomasterfrom
aircraft-remove-unused-base-classes
Jun 20, 2025
Merged

Aircraft - Remove unused base classes#10955
PabstMirror merged 2 commits intomasterfrom
aircraft-remove-unused-base-classes

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 commented Jun 10, 2025

When merged this pull request will:

  • Use different base classes to inherit from instead.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Copy Markdown
Contributor

configfile >> "VScrollbar" doesn't exist either as far as I can tell
it's something like

class ScrollBar;
class RscControlsGroup {
	class VScrollbar: ScrollBar {

I tested just replacing line 19 with
class CA_IGUI_elements_group: RscControlsGroupNoScrollbars {
and and removing all scrollbar stuff and it works great because it is doing exactly the same thing

class RscControlsGroupNoScrollbars: RscControlsGroup {
	class VScrollbar: VScrollbar {
		width=0;
	};
	class HScrollbar: HScrollbar {
		height=0;
	};
};

@johnb432
Copy link
Copy Markdown
Contributor Author

I tested just replacing line 19 with class CA_IGUI_elements_group: RscControlsGroupNoScrollbars { and and removing all scrollbar stuff and it works great because it is doing exactly the same thing

Can you commit those changes directly, since you know exactly what else can be removed?

@johnb432 johnb432 marked this pull request as ready for review June 19, 2025 09:08
@johnb432 johnb432 requested a review from PabstMirror June 19, 2025 09:09
@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Jun 19, 2025
@PabstMirror
Copy link
Copy Markdown
Contributor

sorry i never got to this, changes look great

@PabstMirror PabstMirror added this to the 3.20.0 milestone Jun 19, 2025
@PabstMirror PabstMirror merged commit 90670ec into master Jun 20, 2025
3 checks passed
@PabstMirror PabstMirror deleted the aircraft-remove-unused-base-classes branch June 20, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants