Skip to content

Advanced Ballistics - Add support for multiple muzzles#11215

Merged
johnb432 merged 4 commits intoacemod:masterfrom
rekterakathom:ab-muzzlebased
Jan 20, 2026
Merged

Advanced Ballistics - Add support for multiple muzzles#11215
johnb432 merged 4 commits intoacemod:masterfrom
rekterakathom:ab-muzzlebased

Conversation

@rekterakathom
Copy link
Contributor

@rekterakathom rekterakathom commented Jan 2, 2026

When merged this pull request will:

  • Add support for multiple muzzles into AB
  • Change relevant function calls to include muzzle

The function should be fully backwards compatible, e.g function calls that don't include the muzzle parameter should get similar return values as before. The cache is not backwards compatible however, because the name in the cache now includes the muzzle as well.

Without this PR, barrel data will always be fetched from the "main" muzzle (aka the weapon config).

In vanilla, this affects the Type 115 and the MSBS Grot UBS (with #11213).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.20.3 milestone Jan 17, 2026
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 17, 2026
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432 johnb432 merged commit 45aed1f into acemod:master Jan 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants