Irritants (Smoke) - New Component

[BrettMayson]

When merged this pull request will:

• Smoke effects when standing in particles that have blockAIVisibility
• Blur and over expose vision
• Affect spo2 breathing effectiveness
• Adds eye and breathing protection to vanilla facewear, ace arsenal stat bars
• Unrelated hemtt launch for ADT

Considerations:

• Should this affect AI? Could be a setting, my concern would just be performance from a lot of AI. One possible optimization would be to first check if there is a smoke grenade in X meters, but that would cause other sources of smoke to stop working and I don't like that as a "solution"
• Coughing sound effects? Would need to source audio

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[BaerMitUmlaut]

IMO a bit confusing to have a "smoke" addon that does not change the particles, though I can't think of a better name right now.

[Drofseh]

IMO a bit confusing to have a "smoke" addon that does not change the particles, though I can't think of a better name right now.

Should it go in the goggles addon where eyewear is already providing protection from other things?

[rautamiekka]

• Missing macros.
• Inconsistent *_protection spellings.

[BrettMayson]

Should it go in the goggles addon where eyewear is already providing protection from other things?

I agree that smoke is maybe not the best, but I also couldn't think of anything else that'd be better

I don't think this should go in goggles, just because while they are related to face wear, that's about it. There is no overlap in config, settings, or functionality.

[BrettMayson]

After play testing this weekend, I found a problem with vehicles so I've just disabled it when inside one.

I also had someone get the smoke effect standing in a particular spot, so I'll debug that further this week. Otherwise everything seemed to work well

Solved

[PabstMirror]

isInSmoke cost varies based on nearby objects
but in some cases was up to 0.3ms

I think it would be better to run this at a reduced interval instead of everyframe
5 per second should still be a smooth enough transition for the effects?

[BrettMayson]

Ok, so this checks

1. If an explicit config for the vehicle is defined
2. If the attenuation suggests the vehicle is open (except helicopters, which are always considered enclosed unless defined otherwise explicitly)
3. If the seat has a view of the sky

This seems to be good in most cases, and for the niche ones, either the mod or ace compats can explicitly set if the seat is exposed to smoke or not

[PabstMirror]

opps

[BrettMayson]

This has been working well for us, I think most false positives will be dealt with, but the actual time spent using it is still pretty low, just a few hours.

It is possible there could still be false positives, where the player gets themself into some positioning with terrain, grass, etc. that causes it to think they're in smoke and apply the affect.

[OverlordZorn]

Immersion cigs rewrite has cough sounds from the dayz mod uner apl-sa.

Coughing sound effects:
https://github.com/CVO-Org/immersion-cigs-rewrite/blob/main/addons/core/CfgSounds.hpp#L93-L96
https://github.com/CVO-Org/immersion-cigs-rewrite/tree/main/addons/core/data/sounds

The code for it can be found under core/fnc/adv_fatigue
https://github.com/CVO-Org/immersion-cigs-rewrite/blob/main/addons/core/functions/adv_fatigue/fn_cough.sqf

There's even something in there that alerts enemies of you presense if thats of interest.

[OverlordZorn]

Maybe I missed it when scanning over the code, but is there an API way to add "exposure" to a unit?

I would prefer to avoid having to overwrite the actual value each frame but if i could add a baseline that would be great.

Maybe a similar system like the dutyFactor of advanced_fatigue?

[Drofseh]

I still don't love calling this addon smoke, how do you feel about irritants or something like that?