General - Replace CBA_fnc_turretPath with unitTurret

[johnb432]

When merged this pull request will:

• Title.
• In most cases, this should both be a performance and safety improvement.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

I wanted to also change it here, but I wasn't as sure about it:

ACE3/addons/map/functions/fnc_determineMapLight.sqf

Line 28 in d3c5ca8

&& {!((_unit call CBA_fnc_turretPath) in GVAR(vehicleExteriorTurrets))}

Definition of the array is here:

ACE3/addons/map/XEH_postInitClient.sqf

Line 96 in d3c5ca8

GVAR(vehicleExteriorTurrets) = getArray (_cfg >> QGVAR(vehicleExteriorTurrets));

ACE never defines any values, but the documentation says this:
https://ace3.acemod.org/wiki/framework/map-framework

I don't think this ever worked, given it's checking for a turret path within an array of numbers - or am I missing something?
I can fix it in another PR fi it's indeed broken, but I was also thinking of allowing -1 for the driver, as atm the map framework doesn't enable exclusion of the driver seat.

Thoughts?

[PabstMirror]

I think we make most of the compat configs, so vehicleExteriorTurret is probably not being used anywhere
but I don't think it hurts to keep
maybe just update docs to

-ace_map_vehicleExteriorTurrets[] = {12,13};
+ace_map_vehicleExteriorTurrets[] = {{12},{13}};

which I'm pretty sure is what was intended

[Drofseh]

Here too I think

ACE3/addons/captives/functions/fnc_handleAnimChangedHandcuffed.sqf

Lines 27 to 33 in d3c5ca8

	private _turretPath = [];
	{
	_x params ["_xUnit", "", "", "_xTurretPath"];
	if (_unit == _xUnit) exitWith {_turretPath = _xTurretPath};
	} forEach (fullCrew (vehicle _unit));
	TRACE_1("turret Path",_turretPath);
	if (_turretPath isEqualTo []) exitWith {};

[johnb432]

Here too I think

ACE3/addons/captives/functions/fnc_handleAnimChangedHandcuffed.sqf

Lines 27 to 33 in d3c5ca8

	private _turretPath = [];
	{
	_x params ["_xUnit", "", "", "_xTurretPath"];
	if (_unit == _xUnit) exitWith {_turretPath = _xTurretPath};
	} forEach (fullCrew (vehicle _unit));
	TRACE_1("turret Path",_turretPath);
	if (_turretPath isEqualTo []) exitWith {};

I'll make another PR to handle that.