Skip to content

Rangecard - Minor refactor#11247

Merged
johnb432 merged 3 commits intomasterfrom
rangecard-minor-refactor
Jan 20, 2026
Merged

Rangecard - Minor refactor#11247
johnb432 merged 3 commits intomasterfrom
rangecard-minor-refactor

Conversation

@johnb432
Copy link
Contributor

When merged this pull request will:

  • Code cleanup.
    • Removed FUNC(onCloseDialog), as it can be inlined
  • Code optimizations.
  • Changes:
    • Added interaction to remove range card copy. I've always found it annoying that you could create one, but never delete it.
    • You can only copy a range card from someone else if you have a range card yourself.
    • Changed uiNamespace variable name in which the display reference is stored.
    • Changed layout of numbers within the range card slightly. You can compare it with the old one here: https://ace3.acemod.org/img/wiki/feature/ab_ingame.webp
      The top most rows (until 500m) aren't as close to the top of the table rows anymore, but from 500m to about 700m they are closer to the top. It's not perfect, but imo better than before, whilst also simplifying the code.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Jan 17, 2026
#include "..\script_component.hpp"
/*
* Author: joko // Jonas
* Add the Reserve Parachute to Units or Save Backpack if is a Parachute in Unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@PabstMirror PabstMirror added this to the 3.20.3 milestone Jan 17, 2026
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432 johnb432 merged commit 71a26b9 into master Jan 20, 2026
3 of 4 checks passed
@johnb432 johnb432 deleted the rangecard-minor-refactor branch January 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/optimization Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants