Skip to content

Wardrobe - Optimize Replace Handling#11252

Merged
PabstMirror merged 8 commits intoacemod:masterfrom
OverlordZorn:wardrobe-optimise
Jan 29, 2026
Merged

Wardrobe - Optimize Replace Handling#11252
PabstMirror merged 8 commits intoacemod:masterfrom
OverlordZorn:wardrobe-optimise

Conversation

@OverlordZorn
Copy link
Contributor

@OverlordZorn OverlordZorn commented Jan 20, 2026

  • use Hashmap instead of switch statement
  • remove _equipmentType and use typeNumber instead

Problem:
_equipmentType is being used for the itemChangedBegin and itemChangedEnd public API Events.

Changing this will break people's implementation if they use that parameter - is this something we wanna do or do we keep it as is?

@OverlordZorn OverlordZorn marked this pull request as draft January 20, 2026 10:26
@OverlordZorn OverlordZorn marked this pull request as ready for review January 20, 2026 10:39
@OverlordZorn
Copy link
Contributor Author

grafik

based on github search, at least no public rep is using it it seems

@Andx667
Copy link
Contributor

Andx667 commented Jan 20, 2026

Didnt we use it somewhere else in ace? or am i misremembering?

Since wardrobe is kinda new we should use the relative low spread of usage of such events to change them now instead of later.

@LinkIsGrim
Copy link
Member

Wardrobe is new enough that breaking changes should be fine. I don't think there has been adoption besides AWX.

@PabstMirror PabstMirror added this to the 3.20.3 milestone Jan 28, 2026
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Jan 28, 2026
@PabstMirror PabstMirror merged commit e7c4203 into acemod:master Jan 29, 2026
3 checks passed
@OverlordZorn OverlordZorn deleted the wardrobe-optimise branch February 8, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/optimization Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants