Wardrobe - Optimize Replace Handling#11252
Merged
PabstMirror merged 8 commits intoacemod:masterfrom Jan 29, 2026
Merged
Conversation
This reverts commit 4ea3859.
Contributor
Author
Contributor
|
Didnt we use it somewhere else in ace? or am i misremembering? Since wardrobe is kinda new we should use the relative low spread of usage of such events to change them now instead of later. |
Member
|
Wardrobe is new enough that breaking changes should be fine. I don't think there has been adoption besides AWX. |
LinkIsGrim
approved these changes
Jan 28, 2026
PabstMirror
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem:
_equipmentType is being used for the
itemChangedBeginanditemChangedEndpublic API Events.Changing this will break people's implementation if they use that parameter - is this something we wanna do or do we keep it as is?