Minedetector - Remove unused param and format code#11259
Merged
PabstMirror merged 1 commit intomasterfrom Jan 28, 2026
Merged
Conversation
johnb432
added
kind/cleanup
PabstMirror
approved these changes
Jan 28, 2026
jokoho48
reviewed
Jan 28, 2026
| * Public: Yes | ||
| */ | ||
|
|
||
| params [["_unit", objNull, [objNull]], ["_detectorType", "", [""]]]; |
Member
There was a problem hiding this comment.
this is a public function where the header says still detector type as 2nd parameter. not sure if this was more of a bug instead of actually a unused parameter? i think it should return and should also be in general fix
PabstMirror
reviewed
Jan 28, 2026
| false // return | ||
| }; | ||
|
|
||
| private _detectorType = param [1, currentWeapon _unit, [""]]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.