MissileGuidance - Update to use CBA PID#11282
Merged
PabstMirror merged 1 commit intomasterfrom Feb 12, 2026
Merged
Conversation
PabstMirror
reviewed
Feb 8, 2026
| _correctionDistance = 1; | ||
| }; | ||
| private _pid_x = [_p, 0, _d, 0] call CBA_pid_fnc_create; | ||
| private _pid_y = [_p, 0, _d, 0] call CBA_pid_fnc_create; |
Contributor
There was a problem hiding this comment.
do we need to clean these up with deleteLocation at end of pfeh?
or could cba_pid switch to hashes which should get garbage collected?
Contributor
Author
There was a problem hiding this comment.
ah, I didn't realise that these wouldn't be garbage collected. It would be best for CBA to switch to hashes I think
Contributor
There was a problem hiding this comment.
iirc acre creates thousands of these locations and there really shouldn't be any performance impact of them existing so this is a really minor thing
made a cba pr to change over to hashmaps CBATeam/CBA_A3#1811
PabstMirror
approved these changes
Feb 9, 2026
PabstMirror
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.