Skip to content

[Core] Add Support for TOTP / 2FA to LORIS #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 30, 2025
Merged

[Core] Add Support for TOTP / 2FA to LORIS #9972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a81b28e
[test] Upgrade PHPUnit to the latest release
Jul 10, 2025
8e43739
Add classes for generating TOTP and HOTP codes
Jul 10, 2025
afb47fa
WIP -- add middleware to require MFA token
Jul 24, 2025
612a68a
Register and validate 2FA authenticator on my_preferences page
Aug 12, 2025
f098f5d
2FA WIP
Aug 19, 2025
e215d1b
Prompt for MFA code
Aug 20, 2025
d95be13
PHPCS
Aug 20, 2025
4b8b75b
fix phpunit version, start fixing js lints
Aug 21, 2025
fd519d0
fix static tests
Aug 21, 2025
147ba61
Update schema
Aug 21, 2025
4f57373
Add TOTPSecret to unittest
Aug 21, 2025
4054902
Refactor my_preferences and login prompts to use the same input
Aug 25, 2025
d1c3b8a
Fix space between words
Aug 26, 2025
7ba70f4
Fix comments in tests
Aug 26, 2025
d258537
Add jefferson's suggestions
driusan Aug 27, 2025
bf65e9e
fix compile and explicitly name acronym in link
Aug 27, 2025
a6829e9
Fix manual code input
Aug 27, 2025
b1fe0c3
Fix breadcrumb links
Aug 27, 2025
d3f1d1f
Restore phpunit version after rebase
Oct 30, 2025
937d9f8
Add translatons after rebase
Oct 30, 2025
a9921c0
Add missing file
Oct 30, 2025
08728fc
WIP
Oct 30, 2025
a39c060
add mising file
Oct 30, 2025
559675c
WIP
Oct 30, 2025
78fb8da
Fix Translations
Oct 30, 2025
ab5e165
phan
Oct 30, 2025
de802f3
lint js
Oct 30, 2025
4a505ac
Update template
Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ locales:
msgfmt -o modules/module_manager/locale/ja/LC_MESSAGES/module_manager.mo modules/module_manager/locale/ja/LC_MESSAGES/module_manager.po
msgfmt -o modules/mri_violations/locale/ja/LC_MESSAGES/mri_violations.mo modules/mri_violations/locale/ja/LC_MESSAGES/mri_violations.po
msgfmt -o modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.mo modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.po
npx i18next-conv -l ja -s modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.po -t modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.json --compatibilityJSON v4
npx i18next-conv -l hi -s modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.po -t modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.json --compatibilityJSON v4
msgfmt -o modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.mo modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.po
msgfmt -o modules/next_stage/locale/ja/LC_MESSAGES/next_stage.mo modules/next_stage/locale/ja/LC_MESSAGES/next_stage.po
msgfmt -o modules/next_stage/locale/es/LC_MESSAGES/next_stage.mo modules/next_stage/locale/es/LC_MESSAGES/next_stage.po
msgfmt -o modules/oidc/locale/ja/LC_MESSAGES/oidc.mo modules/oidc/locale/ja/LC_MESSAGES/oidc.po
Expand Down Expand Up @@ -198,3 +201,8 @@ server_processes_manager: modules/server_processes_manager/locale/ja/LC_MESSAGES

conflict_resolver:
target=conflict_resolver npm run compile

my_preferences: modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.mo modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.mo
npx i18next-conv -l ja -s modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.po -t modules/my_preferences/locale/ja/LC_MESSAGES/my_preferences.json --compatibilityJSON v4
npx i18next-conv -l hi -s modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.po -t modules/my_preferences/locale/hi/LC_MESSAGES/my_preferences.json --compatibilityJSON v4
target=my_preferences npm run compile
1 change: 1 addition & 0 deletions SQL/0000-00-00-schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ CREATE TABLE `users` (
`Active` enum('Y','N') NOT NULL default 'Y',
`Password_hash` varchar(255) default NULL,
`PasswordChangeRequired` tinyint(1) NOT NULL default 0,
`TOTPSecret` binary(64) DEFAULT NULL,
`Pending_approval` enum('Y','N') default 'Y',
`Doc_Repo_Notifications` enum('Y','N') default 'N',
`language_preference` integer unsigned default NULL,
Expand Down
1 change: 1 addition & 0 deletions SQL/New_patches/2025-08-21-add_totp_support.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE users ADD COLUMN TOTPSecret binary(64) DEFAULT NULL AFTER PasswordChangeRequired;
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
"laminas/laminas-diactoros" : "^3.5",
"ext-json": "*",
"bjeavons/zxcvbn-php": "^1.0",
"aws/aws-sdk-php": "^3.209"
"aws/aws-sdk-php": "^3.209",
"selective/base32": "^2.0",
"chillerlan/php-qrcode": "^5.0"
},
"require-dev" : {
"squizlabs/php_codesniffer" : "^3.5",
Expand Down
Loading
Loading