Refactor number validation logic and fix typos

BrainPortal/app/models/background_activity.rb

@@ -362,7 +362,7 @@ def remaining_items
   # +failed_items+ and +successful_items+.  These two methods
   # actually indirectly invoke this method here.
   #
-  # By convention, a succesfully processed item is
+  # By convention, a successfully processed item is
   # generally recorded as a nil in the message array,
   # and a failed or skipped item is recorded with
   # a short message. So this method can be used to:
@@ -688,7 +688,7 @@ def setup_retry!
     # everything so we don't need to adjust the list.
     # If the bac is in PartiallyCompleted state,
     # we extract just the elements to try again.
-    if self.status = "PartiallyCompleted"
+    if self.status == "PartiallyCompleted"
       new_items = self.failed_items
       if new_items.blank?
         self.internal_error!('No items list after retry')

BrainPortal/app/models/boutiques_portal_task.rb

@@ -568,7 +568,7 @@ def sanitize_param(input)
       when :number
         if value.blank?
           params_errors.add(invokename, ": value missing")
-        elsif (number = Integer(value) rescue Float(value) rescue nil)
+        elsif (number = (Integer(value) rescue Float(value) rescue nil))
           value = number
         else
           params_errors.add(invokename, ": not a number (#{value})")
@@ -664,7 +664,7 @@ def check_number_param(input)
       ok = values.all? { |v| v <  input.maximum.to_f } if clusive == 'exclusive'
       ok = values.all? { |v| v <= input.maximum.to_f } if clusive == 'inclusive'
       if ! ok
-        params_errors.add(input.cb_invoke_name, "violates #{clusive} maximum value #{input.minimum}")
+        params_errors.add(input.cb_invoke_name, "violates #{clusive} maximum value #{input.maximum}")
       end
     end
 

BrainPortal/lib/boutiques_allowed_exit_codes.rb

@@ -21,7 +21,7 @@
 #
 
 # This module allows a Boutiques task to be considered
-# succesful even when the command's return code is
+# successful even when the command's return code is
 # something other than zero.
 #
 # To include the module automatically at boot time