Skip to content

Fix typos, grammar errors, and a logic bug in noc_controller#1600

Merged
prioux merged 1 commit intoaces:masterfrom
RafsanNeloy:noc_controller
Mar 10, 2026
Merged

Fix typos, grammar errors, and a logic bug in noc_controller#1600
prioux merged 1 commit intoaces:masterfrom
RafsanNeloy:noc_controller

Conversation

@RafsanNeloy
Copy link
Contributor

Fixed spelling/grammar issues across 38 files (acces→access, overriden→overridden,
occured→occurred, environement→environment, and more). Also fixed a logic bug in
noc_controller.rb where / 24.hours incorrectly computed a fraction of a day instead of hours.

Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
@prioux
Copy link
Member

prioux commented Mar 9, 2026

The code in noc_controllers was supposed to compute a fraction of a day, I think. It doesn't matter, because that particular line of code is dead (the variable @num_hours is not used anywhere)

@prioux
Copy link
Member

prioux commented Mar 9, 2026

I'll review the typos and approve later

@prioux prioux merged commit e9d6f9a into aces:master Mar 10, 2026
1 check passed
@RafsanNeloy
Copy link
Contributor Author

The code in noc_controllers was supposed to compute a fraction of a day, I think. It doesn't matter, because that particular line of code is dead (the variable @num_hours is not used anywhere)

Should I remove that particular deadl line of code in noc_controller?

@prioux
Copy link
Member

prioux commented Mar 11, 2026

I already did. See the commit that I created immediately after I merged your PR. (It was literally 3 minutes later): 0c0656f

@RafsanNeloy RafsanNeloy deleted the noc_controller branch March 12, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants