Fix typos, grammar errors, and a logic bug in noc_controller#1600
Merged
prioux merged 1 commit intoaces:masterfrom Mar 10, 2026
Merged
Fix typos, grammar errors, and a logic bug in noc_controller#1600prioux merged 1 commit intoaces:masterfrom
prioux merged 1 commit intoaces:masterfrom
Conversation
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
Member
|
The code in noc_controllers was supposed to compute a fraction of a day, I think. It doesn't matter, because that particular line of code is dead (the variable |
Member
|
I'll review the typos and approve later |
Contributor
Author
Should I remove that particular deadl line of code in |
Member
|
I already did. See the commit that I created immediately after I merged your PR. (It was literally 3 minutes later): 0c0656f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed spelling/grammar issues across 38 files (acces→access, overriden→overridden,
occured→occurred, environement→environment, and more). Also fixed a logic bug in
noc_controller.rbwhere/ 24.hoursincorrectly computed a fraction of a day instead of hours.