chore(CI): remove credential build arguments to move docker image to public registry#251
Open
JulesFiliot wants to merge 2 commits intodevelopfrom
Open
chore(CI): remove credential build arguments to move docker image to public registry#251JulesFiliot wants to merge 2 commits intodevelopfrom
JulesFiliot wants to merge 2 commits intodevelopfrom
Conversation
Contributor
JulesFiliot
commented
Dec 22, 2025
JulesFiliot
commented
- remove credential build arguments to allow moving the docker image to a public registry
- c.f. this discord conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@jinhojang6 if you remember that this token ab92e72 was left in hardcoded intentionally please tell me and I will revert the change 👍 |
Collaborator
|
@JulesFiliot I am not aware of this because it was done by an old CC, but I think we'd better remove the hard-coded value. Thanks for the heads-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.