Skip to content

Removed comments from XML #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −10
Open

Removed comments from XML #2763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bin/anthology/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,6 @@ def parse_element(
return attrib

for element in xml_element:
if element.tag is etree.Comment:
continue

# parse value
tag = element.tag.lower()
if tag in dont_parse_elements:
Expand Down
9 changes: 3 additions & 6 deletions data/xml/2023.ws.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@
<collection id="2023.ws">
<event id="ws-2023">
<colocated>
<!-- Unsorted -->
<volume-id>2023.computel-1</volume-id>
<volume-id note="unsorted">2023.computel-1</volume-id>
<volume-id>2023.wsc-csdh</volume-id>
<volume-id>2023.depling-1</volume-id>
<volume-id>2023.cxgsnlp-1</volume-id>
<volume-id>2023.tlt-1</volume-id>
<volume-id>2023.udw-1</volume-id>
<volume-id>2023.resourceful-1</volume-id>
<volume-id>2023.nlp4call-1</volume-id>
<!-- EACL 2023 -->
<volume-id>2023.bsnlp-1</volume-id>
<volume-id note="eacl">2023.bsnlp-1</volume-id>
<volume-id>2023.c3nlp-1</volume-id>
<volume-id>2023.fever-1</volume-id>
<volume-id>2023.fieldmatters-1</volume-id>
Expand All @@ -24,8 +22,7 @@
<volume-id>2023.sigtyp-1</volume-id>
<volume-id>2023.unlp-1</volume-id>
<volume-id>2023.vardial-1</volume-id>
<!-- ACL 2023 -->
<volume-id>2023.americasnlp-1</volume-id>
<volume-id note="acl">2023.americasnlp-1</volume-id>
<volume-id>2023.bea-1</volume-id>
<volume-id>2023.bionlp-1</volume-id>
<volume-id>2023.cawl-1</volume-id>
Expand Down
2 changes: 1 addition & 1 deletion data/xml/schema.rnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ Event = element event {
& element links { url* }?
& Talk*
& element colocated {
element volume-id { text }*
element volume-id { attribute note { xsd:string }?, text }*
}?
)
}
Expand Down