Skip to content

Conversation

@Azax4
Copy link
Collaborator

@Azax4 Azax4 commented Nov 10, 2025

(Please replace this text with a description of the changes effected by this pull request.
Include a link to the corresponding Github Issue, if there is one.
Details on how to do this (can be found here).)

@Azax4 Azax4 added this to the 2025Q4 milestone Nov 10, 2025
@Azax4 Azax4 self-assigned this Nov 10, 2025
@mbollmann
Copy link
Member

Any reason this uses XML parsing rather than the Python library? This is much harder to maintain...

@Azax4
Copy link
Collaborator Author

Azax4 commented Nov 10, 2025

I was mostly using bin/add_author_id.py as a reference. Tweaked it just a little bit to take the year as input instead of file ids

@mbollmann
Copy link
Member

Ah, okay. Makes sense if it was the easiest solution. But that’s another good reason we should switch our scripts to the Python library or mark them as outdated @mjpost 😅

@mjpost
Copy link
Member

mjpost commented Nov 10, 2025

@Azax4 let's do this now—can you please port this to the library? We've got to switch sometime and now's the moment.

@mjpost
Copy link
Member

mjpost commented Nov 10, 2025

(Also you probably need to run make reformat here to pass the check)

@Azax4
Copy link
Collaborator Author

Azax4 commented Nov 14, 2025

Got it, working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants