-
Notifications
You must be signed in to change notification settings - Fork 365
Added Enfa Fane name variants #6429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
|
Here is my summary so far:
|
weissenh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a) add comment field.
(b) add id everywhere or let me know why this wasn't done
| - {first: Enfa Rose, last: George} | ||
| - {first: Enfa, last: George} | ||
| orcid: 0000-0001-7689-8740 | ||
| institution: University Of Arizona |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment field too?
Degree institution is not mentioned on https://preview.aclanthology.org/name-variant-enfa-fane/people/enfa-fane/
The papers on this page seem to all stem from this person and the issue submitter implicitly confirmed this plus further evidence from the ORCID page (though as arXiv preprints listed there) and showing same affiliation and email address for this author on all PDFs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an id be assigned to all 6 papers in the xml and mentioned in name variants? We know for certain all 6 papers belong to the same person
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't need to assign IDs in the XML unless the name is ambiguous. I.e. for simply merging, adding the name variant in the YAML file is enough. This logic will change under the new system.
(Please replace this text with a description of the changes effected by this pull request.
Include a link to the corresponding Github Issue, if there is one.
Details on how to do this (can be found here).)