Skip to content

Conversation

@Azax4
Copy link
Collaborator

@Azax4 Azax4 commented Nov 10, 2025

(Please replace this text with a description of the changes effected by this pull request.
Include a link to the corresponding Github Issue, if there is one.
Details on how to do this (can be found here).)

@Azax4 Azax4 added this to the Author page backlog milestone Nov 10, 2025
@Azax4 Azax4 self-assigned this Nov 10, 2025
@Azax4 Azax4 linked an issue Nov 10, 2025 that may be closed by this pull request
3 tasks
@github-actions
Copy link

Build successful. Some useful links:

This preview will be removed when the branch is merged.

@Azax4 Azax4 requested a review from weissenh November 14, 2025 19:02
@weissenh
Copy link
Contributor

Here is my summary so far:

Copy link
Contributor

@weissenh weissenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a) add comment field.
(b) add id everywhere or let me know why this wasn't done

- {first: Enfa Rose, last: George}
- {first: Enfa, last: George}
orcid: 0000-0001-7689-8740
institution: University Of Arizona
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment field too?

Degree institution is not mentioned on https://preview.aclanthology.org/name-variant-enfa-fane/people/enfa-fane/
The papers on this page seem to all stem from this person and the issue submitter implicitly confirmed this plus further evidence from the ORCID page (though as arXiv preprints listed there) and showing same affiliation and email address for this author on all PDFs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an id be assigned to all 6 papers in the xml and mentioned in name variants? We know for certain all 6 papers belong to the same person

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't need to assign IDs in the XML unless the name is ambiguous. I.e. for simply merging, adding the name variant in the YAML file is enough. This logic will change under the new system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Author Page: enfa-fane

4 participants