-
Notifications
You must be signed in to change notification settings - Fork 365
Added author page for Diogo Silva #6474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| <author><first>Daniel M.</first><last>Pedrozo</last></author> | ||
| <author><first>Artur M. A.</first><last>Novais</last></author> | ||
| <author><first>Diogo F. C.</first><last>Silva</last></author> | ||
| <author id="diogo-silva"><first>Diogo F. C.</first><last>Silva</last></author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice how this one doesn't have "Gloria" in it and the first name contains an additional "F.C."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure there are not two catch-alls left and they are still linked to the singled out one.
To see what I mean, please have a look at the following three four URLs and critically think about (a) whether the page needs to exist, (b) what the canonical name or listed name variants should be and (c) whether links to other pages have the proper comment behind them:
- https://preview.aclanthology.org/author-page-diogo-silva-nova/people/diogo-silva/ (status quo: 1 paper, but not with Gloria somewhere)
- https://preview.aclanthology.org/author-page-diogo-silva-nova/people/diogo-gloria-silva/ (status quo: exists, but empty)
- https://preview.aclanthology.org/author-page-diogo-silva-nova/people/diogo-silva-nova/ (status quo: lists 4 papers requested by issue submitter)
- https://preview.aclanthology.org/author-page-diogo-silva-nova/people/diogo-gloria-silva-nova/ (status quo: gives 404)
Questions:
- Should the singled out user be
diogo-gloria-silva-novaordiogo-silva-nova? - Should the catch-all have 'Gloria' in is canonical name?
- Do we need 3 pages? Or just two of the above? If two, which ones?
- Are the pages properly linked once my requested changes have been implemented? (Please check again)
Otherwise: ✔️
singled out papers seem to match requested changes by issue submitter, have consistent affiliation, and partially orcid/listed on orcid.org, metadata matching PDF. Note that the oldest of the 4 papers doesn't include the Gloria part, so this person did publish under two slightly different name variants. NOVA seems to be current and degree institution. No mismatch in xml tags found by looking at diff
| orcid: 0000-0002-4420-7455 | ||
| institution: NOVA University of Lisbon, School of Science and Technology | ||
| comment: NOVA | ||
| - canonical: {first: Diogo, last: Glória-Silva} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch-all shouldn't have the "Gloria" part in here, there is simply no evidence for it and it is confusing.
The only paper left in catch-all ( 2025.semeval-1.300) mentions as author "Diogo F.C. Silva".
- Please correct the canonical name for the catch-all
- Please check whether you need
similaror other measure to make it appear as "Other people with similar names" for the singled-out Diogo from NOVA.
(Please replace this text with a description of the changes effected by this pull request.
Include a link to the corresponding Github Issue, if there is one.
Details on how to do this (can be found here).)