-
Notifications
You must be signed in to change notification settings - Fork 365
Added name variant for V.G.Vinod Vydiswaran #6478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
| - {first: Jeongwon, last: Cha} | ||
| - canonical: {first: V.G.Vinod, last: Vydiswaran} | ||
| variants: | ||
| - {first: VG Vinod, last: Vydiswaran} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I believe there are more papers where metadata and PDF content might not fully match. Some of this might be irrelevant for getting the paper on the same author page (so not sure which ones we need to list in the yaml explicitly, cf. https://github.com/acl-org/acl-anthology/wiki/Name-Variants ) , but it is nonetheless a slight inconsistency.
On the page with metadata displayed as "V.G.Vinod Vydiswaran" (without space in first name) I find papers with the following name copied from the PDF:
- 2024.findings-emnlp.145 VG Vinod Vydiswaran (no punctuation, space added)
- 2024.naacl-long.165 V.G. Vinod Vydiswaran (space added)
- 2023.findings-acl.561 V.G. Vinod Vydiswaran (space added)
- I17-1040 V. G. Vinod Vydiswaran (two! spaces added)
- N10-4008 V.G. Vinod Vydiswaran (space added)
| - canonical: {first: Jeong-Won, last: Cha} | ||
| variants: | ||
| - {first: Jeongwon, last: Cha} | ||
| - canonical: {first: V.G.Vinod, last: Vydiswaran} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue submitter has provided an orcid. Why not add orcidand id field here?
Future papers can be mapped by orcid, issue submitter wasn't clear about it but I assume all papers currently listed on the page belong to the person, so we could verify the paper and person.
edit: and institution (or degree field) and comment field
weissenh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done a full review yet, and will continue after the requested changes have been implemented (or argued why not necessary):
- add
orcid,id,institution/degree,commentand if needed morevariantsto the yaml file - correct further papers with metadata - PDF inconsistencies (spacing /with or without punctuation in first name)
- after above two done, check https://preview.aclanthology.org/name-variant-v-g-vinod-vydiswaran/people/v-g-vinod-vydiswaran/ still contains the right number of papers plus relevant name variants listed along with institution
(Please replace this text with a description of the changes effected by this pull request.
Include a link to the corresponding Github Issue, if there is one.
Details on how to do this (can be found here).)