Skip to content

Fix infinite recomposition when state properties used in composition #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kemalatli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix infinite recomposition when state properties used in composition #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions reorderable/src/commonMain/kotlin/org/burnoutcrew/reorderable/ReorderableState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ abstract class ReorderableState<T>(
internal val interactions = Channel<StartDrag>()
internal val scrollChannel = Channel<Float>()
val draggingItemLeft: Float
get() = draggingLayoutInfo?.let { item ->
get() = if(draggingItemKey!=null) draggingLayoutInfo?.let { item ->
(selected?.left ?: 0) + draggingDelta.x - item.left
} ?: 0f
} ?: 0f else 0f
val draggingItemTop: Float
get() = draggingLayoutInfo?.let { item ->
get() = if(draggingItemKey!=null) draggingLayoutInfo?.let { item ->
(selected?.top ?: 0) + draggingDelta.y - item.top
} ?: 0f
} ?: 0f else 0f
abstract val isVerticalScroll: Boolean
private val draggingLayoutInfo: T?
get() = visibleItemsInfo
Expand Down