Skip to content

Linkry Test Suite #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2025
Merged

Linkry Test Suite #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4712254
Linkry test suite updated
EthM370 Apr 21, 2025
b21e915
Minor fix
EthM370 Apr 21, 2025
a9e45aa
Linkry test suite updated
EthM370 Apr 21, 2025
91be499
Minor fix
EthM370 Apr 21, 2025
5f01233
Force unit tests to run
devksingh4 Apr 21, 2025
66df463
change base branch
devksingh4 Apr 21, 2025
d1ab020
Linkry test suite addition & fixes
EthM370 Apr 22, 2025
a8c6502
Merged
EthM370 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/routes/linkry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,9 @@ const linkryRoutes: FastifyPluginAsync = async (fastify, _options) => {
setUserGroups,
);
if (mutualGroups.size == 0) {
throw new NotFoundError({ endpointName: request.url });
throw new UnauthorizedError({
message: "You have not been delegated access.",
});
}
}
return reply.status(200).send(item);
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/auth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const ddbMock = mockClient(SecretsManagerClient);

const app = await init();
const jwt_secret = secretObject["jwt_key"];
export function createJwt(date?: Date, group?: string, email?: string) {
export function createJwt(date?: Date, groups?: string[], email?: string) {
let modifiedPayload = {
...jwtPayload,
email: email || jwtPayload.email,
Expand All @@ -36,8 +36,8 @@ export function createJwt(date?: Date, group?: string, email?: string) {
};
}

if (group) {
modifiedPayload.groups = [group];
if (groups) {
modifiedPayload.groups = groups;
}
return jwt.sign(modifiedPayload, jwt_secret, { algorithm: "HS256" });
}
Expand Down
10 changes: 5 additions & 5 deletions tests/unit/eventPost.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test("Sad path: Not authenticated", async () => {

test("Sad path: Authenticated but not authorized", async () => {
await app.ready();
const testJwt = createJwt(undefined, "1");
const testJwt = createJwt(undefined, ["1"]);
const response = await supertest(app.server)
.post("/api/v1/events")
.set("Authorization", `Bearer ${testJwt}`)
Expand All @@ -66,7 +66,7 @@ test("Sad path: Authenticated but not authorized", async () => {
});
test("Sad path: Prevent empty body request", async () => {
await app.ready();
const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);
const response = await supertest(app.server)
.post("/api/v1/events")
.set("Authorization", `Bearer ${testJwt}`)
Expand Down Expand Up @@ -227,7 +227,7 @@ describe("ETag Lifecycle Tests", () => {
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. Check initial etag for all events is 0
const initialAllResponse = await app.inject({
Expand Down Expand Up @@ -313,7 +313,7 @@ describe("ETag Lifecycle Tests", () => {
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. Create an event
const eventResponse = await supertest(app.server)
Expand Down Expand Up @@ -413,7 +413,7 @@ describe("ETag Lifecycle Tests", () => {
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. Check initial etag for all events is 0
const initialAllResponse = await app.inject({
Expand Down
10 changes: 5 additions & 5 deletions tests/unit/events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test("ETag should increment after event creation", async () => {
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. Check initial etag for all events is 0
const initialAllResponse = await app.inject({
Expand Down Expand Up @@ -138,7 +138,7 @@ test("Should return 304 Not Modified when If-None-Match header matches ETag", as
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. First GET request to establish ETag
const initialResponse = await app.inject({
Expand Down Expand Up @@ -188,7 +188,7 @@ test("Should return 304 Not Modified when If-None-Match header matches quoted ET
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. First GET request to establish ETag
const initialResponse = await app.inject({
Expand Down Expand Up @@ -238,7 +238,7 @@ test("Should NOT return 304 when ETag has changed", async () => {
Items: [],
});

const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);

// 1. Initial GET to establish ETag
const initialResponse = await app.inject({
Expand Down Expand Up @@ -313,7 +313,7 @@ test("Should handle 304 responses for individual event endpoints", async () => {
ddbMock.on(PutItemCommand).resolves({});

// Create an event
const testJwt = createJwt(undefined, "0");
const testJwt = createJwt(undefined, ["0"]);
const eventResponse = await supertest(app.server)
.post("/api/v1/events")
.set("Authorization", `Bearer ${testJwt}`)
Expand Down
Loading
Loading