Skip to content

Cleanup references to old services, rename merch to store#272

Merged
devksingh4 merged 6 commits intomainfrom
rename-and-cleanup
Jan 31, 2026
Merged

Cleanup references to old services, rename merch to store#272
devksingh4 merged 6 commits intomainfrom
rename-and-cleanup

Conversation

@devksingh4
Copy link
Member

@devksingh4 devksingh4 commented Jan 31, 2026

Summary by CodeRabbit

  • Refactor

    • Unified merchandising and event purchase flows under a single "Store" experience; updated navigation text/link from "Merch" to "Store".
    • Consolidated internal routes and link targets to /store and /store/item.
    • Removed legacy per-id redirects for event/merch and added a /merch → /store redirect.
  • New Features

    • Added a dedicated store "paid" confirmation page with a success modal.
  • Chores

    • Removed several public-facing environment variable definitions from environment files.

✏️ Tip: You can customize this high-level summary in your review settings.

@devksingh4 devksingh4 requested review from a team as code owners January 31, 2026 21:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026

Warning

Rate limit exceeded

@devksingh4 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

This PR removes separate event and merch-paid page components and replaces merch-store routes with store routes. It deletes environment variable entries for ticketing, membership, and merch APIs across development, staging, and production .env files. Redirects for per-id event and merch paths were removed and a /merch -> /store redirect was added. Multiple components and navigation entries were updated to use /store and /store/item routes (including CalendarEventDetail, EventCard, Navbar, and several store-related pages), and a new /store/paid page component was introduced.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing environment variables for old external services and renaming merch routes/references to store throughout the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rename-and-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

Deploying with Cloudflare Pages

Name Result
Last commit: ee2f7b4
Preview URL: https://0f4ffb63.acmuiuc.pages.dev
Branch Preview URL: https://rename-and-cleanup.acmuiuc.pages.dev

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Fix all issues with AI agents
In `@src/app/`(membership)/store/item/page.tsx:
- Around line 547-548: Replace the relative redirect path with the absolute path
for consistency: update the window.location.replace('../store') call to use
'/store' so it matches the absolute route used elsewhere (e.g., the `/store`
usage at line 243); ensure the change is made where the redirect occurs (the
window.location.replace(...) call) and keep the returned <Layout name="Store">
unchanged.
- Around line 407-408: The redirect paths for the guest checkout are wrong;
update the values for successRedirPath and cancelRedirPath (the properties in
the guest checkout payload) so successRedirPath is "/store/paid" (not
"/store-paid") and cancelRedirPath is "/store/item?id=${itemid}" (include the
"item" segment and interpolate itemid variable); locate the object/handler that
sets successRedirPath and cancelRedirPath in the guest checkout flow and replace
the two strings accordingly.

In `@src/app/`(membership)/store/page.tsx:
- Line 93: The href value in the JSX (href={'../store/item?id=' +
val['item_id']}) is using a fragile relative path; update the href to an
absolute path (e.g., '/store/item?id=' + val['item_id'] or using a template
string) in the component in page.tsx so it becomes '/store/item?id={item_id}'
(reference the JSX expression that builds href and the val['item_id'] variable)
to ensure stability if file structure changes.

In `@src/app/`(membership)/store/paid/page.tsx:
- Line 28: The Layout component instance in the paid store page is missing the
name prop; update the Layout usage to include name="Store" to match other store
pages (refer to Layout in store/page.tsx and store/item/page.tsx) so the prop is
passed consistently across pages.
- Around line 2-15: Remove the unused imports in this module: delete useState
from the React import, remove useSearchParams, drop axios, and drop
transformApiResponse; update the import block near the top of
src/app/(membership)/store/paid/page.tsx so only used symbols remain (e.g.,
Suspense, useEffect, Modal components, Lottie, Layout, successAnimation), and
ensure no code references the removed identifiers before committing.

size="lg"
as={Link}
href={'../merch?id=' + val['item_id']}
href={'../store/item?id=' + val['item_id']}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider using absolute path for href.

The relative path ../store/item?id= works but is fragile if the file structure changes. Using an absolute path improves clarity and maintainability.

Suggested change
                   <Button
                     color="primary"
                     size="lg"
                     as={Link}
-                    href={'../store/item?id=' + val['item_id']}
+                    href={'/store/item?id=' + val['item_id']}
                   >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
href={'../store/item?id=' + val['item_id']}
href={'/store/item?id=' + val['item_id']}
🤖 Prompt for AI Agents
In `@src/app/`(membership)/store/page.tsx at line 93, The href value in the JSX
(href={'../store/item?id=' + val['item_id']}) is using a fragile relative path;
update the href to an absolute path (e.g., '/store/item?id=' + val['item_id'] or
using a template string) in the component in page.tsx so it becomes
'/store/item?id={item_id}' (reference the JSX expression that builds href and
the val['item_id'] variable) to ensure stability if file structure changes.

devksingh4 and others added 4 commits January 31, 2026 15:53
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@devksingh4 devksingh4 merged commit e5a6707 into main Jan 31, 2026
5 checks passed
@devksingh4 devksingh4 deleted the rename-and-cleanup branch January 31, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant