Skip to content

Add address to website#306

Merged
devksingh4 merged 1 commit intomainfrom
add-mailing-address
Feb 23, 2026
Merged

Add address to website#306
devksingh4 merged 1 commit intomainfrom
add-mailing-address

Conversation

@devksingh4
Copy link
Member

@devksingh4 devksingh4 commented Feb 23, 2026

Summary by CodeRabbit

  • New Features
    • Added a new social link button in the hero section with a map-pin icon directing users to ACM @ UIUC room maps
    • Added postal mailing address for ACM @ UIUC on the About page under the Contact Us section for users seeking physical location information

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Walkthrough

The changes add new contact information for ACM @ UIUC across the codebase. A new constant acmRoomMapsLink is introduced in the constants file. This link is then used to add a social navigation button in the Hero component with a map-pin icon. Additionally, a postal mailing address block for ACM @ UIUC is added to the About page's Contact Us section. These are purely additive changes with no modifications to existing logic or functionality.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Add address to website' accurately reflects the main change: adding a postal mailing address to the website's About page, along with a supporting map link constant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-mailing-address

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 2b99a10
Preview URL: https://d4e44290.acmuiuc.pages.dev
Branch Preview URL: https://add-mailing-address.acmuiuc.pages.dev

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
src/pages/about.mdx (1)

64-70: Prefer <address> over a code block for a postal address.

A Markdown code block renders as <pre><code>, which is semantically intended for source code or technical content — not physical addresses. Screen readers may announce the block as code, which is misleading. MDX supports inline HTML, so the HTML <address> element (purpose-built for contact/address information) can be used directly.

♻️ Suggested replacement
-```
-ACM @ UIUC
-201 N Goodwin Avenue
-Room 1104
-Urbana, IL 61801-2302
-United States of America
-```
+<address>
+  ACM @ UIUC<br />
+  201 N Goodwin Avenue<br />
+  Room 1104<br />
+  Urbana, IL 61801-2302<br />
+  United States of America
+</address>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/pages/about.mdx` around lines 64 - 70, Replace the fenced code block
containing the postal address with a semantic HTML <address> element: remove the
triple-backtick block and instead insert an <address> tag containing the lines
of the address separated by <br /> (e.g., "ACM @ UIUC", "201 N Goodwin Avenue",
"Room 1104", "Urbana, IL 61801-2302", "United States of America"); ensure MDX
inline HTML is valid (self-closing <br />) and no surrounding code block markers
remain so screen readers and semantics are correct.
src/constants.ts (1)

4-4: Replace the maps.app.goo.gl short link with the canonical Google Maps URL to remove dependency on deprecated Firebase Dynamic Links infrastructure.

maps.app.goo.gl links are backed by Firebase Dynamic Links, which were officially sunset on August 25, 2025. While some links continue to resolve during a gradual shutdown phase, the underlying infrastructure is no longer maintained, and browsers like Brave on Android have already reported failures. Use the canonical URL instead:

https://www.google.com/maps/place/Association+For+Computing+Machinery/@40.113938,-88.2277449,2379m/data=!3m2!1e3!5s0x880cd76a59dfc601:0x241c8874383c4540!4m6!3m5!1s0x880cd76baa8479a9:0xb57fb160a4857c0a!8m2!3d40.113938!4d-88.22517!16s%2Fg%2F1tfpkd80?entry=tts&g_ep=EgoyMDI2MDIxOC4wIPu8ASoASAFQAw%3D%3D&skid=c1d90a33-995c-4e94-b820-17fcf15cb8c0
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/constants.ts` at line 4, Replace the deprecated Firebase Dynamic Link
string assigned to the constant acmRoomMapsLink with the provided canonical
Google Maps URL; update the export const acmRoomMapsLink value to the full
https://www.google.com/maps/... URL in src/constants.ts so the app no longer
depends on maps.app.goo.gl short links.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/constants.ts`:
- Line 4: Replace the deprecated Firebase Dynamic Link string assigned to the
constant acmRoomMapsLink with the provided canonical Google Maps URL; update the
export const acmRoomMapsLink value to the full https://www.google.com/maps/...
URL in src/constants.ts so the app no longer depends on maps.app.goo.gl short
links.

In `@src/pages/about.mdx`:
- Around line 64-70: Replace the fenced code block containing the postal address
with a semantic HTML <address> element: remove the triple-backtick block and
instead insert an <address> tag containing the lines of the address separated by
<br /> (e.g., "ACM @ UIUC", "201 N Goodwin Avenue", "Room 1104", "Urbana, IL
61801-2302", "United States of America"); ensure MDX inline HTML is valid
(self-closing <br />) and no surrounding code block markers remain so screen
readers and semantics are correct.

@devksingh4 devksingh4 merged commit 4839d30 into main Feb 23, 2026
16 of 18 checks passed
@devksingh4 devksingh4 deleted the add-mailing-address branch February 23, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant