Conversation
WalkthroughThe changes add new contact information for ACM @ UIUC across the codebase. A new constant Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/pages/about.mdx (1)
64-70: Prefer<address>over a code block for a postal address.A Markdown code block renders as
<pre><code>, which is semantically intended for source code or technical content — not physical addresses. Screen readers may announce the block as code, which is misleading. MDX supports inline HTML, so the HTML<address>element (purpose-built for contact/address information) can be used directly.♻️ Suggested replacement
-``` -ACM @ UIUC -201 N Goodwin Avenue -Room 1104 -Urbana, IL 61801-2302 -United States of America -``` +<address> + ACM @ UIUC<br /> + 201 N Goodwin Avenue<br /> + Room 1104<br /> + Urbana, IL 61801-2302<br /> + United States of America +</address>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/about.mdx` around lines 64 - 70, Replace the fenced code block containing the postal address with a semantic HTML <address> element: remove the triple-backtick block and instead insert an <address> tag containing the lines of the address separated by <br /> (e.g., "ACM @ UIUC", "201 N Goodwin Avenue", "Room 1104", "Urbana, IL 61801-2302", "United States of America"); ensure MDX inline HTML is valid (self-closing <br />) and no surrounding code block markers remain so screen readers and semantics are correct.src/constants.ts (1)
4-4: Replace themaps.app.goo.glshort link with the canonical Google Maps URL to remove dependency on deprecated Firebase Dynamic Links infrastructure.
maps.app.goo.gllinks are backed by Firebase Dynamic Links, which were officially sunset on August 25, 2025. While some links continue to resolve during a gradual shutdown phase, the underlying infrastructure is no longer maintained, and browsers like Brave on Android have already reported failures. Use the canonical URL instead:https://www.google.com/maps/place/Association+For+Computing+Machinery/@40.113938,-88.2277449,2379m/data=!3m2!1e3!5s0x880cd76a59dfc601:0x241c8874383c4540!4m6!3m5!1s0x880cd76baa8479a9:0xb57fb160a4857c0a!8m2!3d40.113938!4d-88.22517!16s%2Fg%2F1tfpkd80?entry=tts&g_ep=EgoyMDI2MDIxOC4wIPu8ASoASAFQAw%3D%3D&skid=c1d90a33-995c-4e94-b820-17fcf15cb8c0🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/constants.ts` at line 4, Replace the deprecated Firebase Dynamic Link string assigned to the constant acmRoomMapsLink with the provided canonical Google Maps URL; update the export const acmRoomMapsLink value to the full https://www.google.com/maps/... URL in src/constants.ts so the app no longer depends on maps.app.goo.gl short links.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/constants.ts`:
- Line 4: Replace the deprecated Firebase Dynamic Link string assigned to the
constant acmRoomMapsLink with the provided canonical Google Maps URL; update the
export const acmRoomMapsLink value to the full https://www.google.com/maps/...
URL in src/constants.ts so the app no longer depends on maps.app.goo.gl short
links.
In `@src/pages/about.mdx`:
- Around line 64-70: Replace the fenced code block containing the postal address
with a semantic HTML <address> element: remove the triple-backtick block and
instead insert an <address> tag containing the lines of the address separated by
<br /> (e.g., "ACM @ UIUC", "201 N Goodwin Avenue", "Room 1104", "Urbana, IL
61801-2302", "United States of America"); ensure MDX inline HTML is valid
(self-closing <br />) and no surrounding code block markers remain so screen
readers and semantics are correct.
Summary by CodeRabbit