Skip to content

Conversation

fergbrain
Copy link

Deploy script for use with a local Plex Media Server. Could help resolve Issues #3474, #3893, and #285

@fergbrain
Copy link
Author

Updated based on failed shellcheck workflow

… Testing with shellcheck v0.8 doesn't yield any flags for SC2154.
@fergbrain
Copy link
Author

Testing with shellcheck v0.8 doesn't yield any flags for SC2154, however, the workflow still failed when running with shellcheck v0.7. This is a known issue and was fixed with shellcheck v0.7.2: "SC2154: Variables appearing in -z/-n tests are no longer considered unassigned"

I've disabled checking for SC2154 for now.

Note: you can test with 0.8 by using https://www.shellcheck.net/, just delete the # shellcheck disable=SC2154 line at the top first.

@fergbrain fergbrain closed this Apr 16, 2023
@fergbrain fergbrain deleted the patch-1 branch April 16, 2023 19:28
@fergbrain fergbrain restored the patch-1 branch September 13, 2024 02:14
@fergbrain fergbrain deleted the patch-1 branch September 13, 2024 02:14
@strausmann
Copy link

Hello @fergbrain,

why was this change not merged into Acme.sh ?

@fergbrain fergbrain mentioned this pull request Jun 10, 2025
@fergbrain
Copy link
Author

@strausmann: Oh good question. I'm not sure what happened. I think it might have been user error on my part. I've resubmitted the patch: #6395

@strausmann
Copy link

I have one suggestion for improvement.

Restarting a local Plex service is a good idea. However, I use acme.sh on my Docker host and Plex in a container, so it would be good if you could customize the restart command using a variable, e.g. to “docker restart ”.

@fergbrain
Copy link
Author

it would be good if you could customize the restart command using a variable, e.g. to “docker restart ”.

@strausmann Good idea! I put my response over in the new pull request: #6395 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants