-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Create plex.sh #3909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plex.sh #3909
Conversation
Deploy script for use with a local Plex Media Server. Could help resolve Issues acmesh-official#3474, acmesh-official#3893, and acmesh-official#285
…g. 'if ! mycmd;', not indirectly with 0.
Updated based on failed shellcheck workflow |
… Testing with shellcheck v0.8 doesn't yield any flags for SC2154.
Testing with shellcheck v0.8 doesn't yield any flags for SC2154, however, the workflow still failed when running with shellcheck v0.7. This is a known issue and was fixed with shellcheck v0.7.2: "SC2154: Variables appearing in -z/-n tests are no longer considered unassigned" I've disabled checking for SC2154 for now. Note: you can test with 0.8 by using https://www.shellcheck.net/, just delete the |
Hello @fergbrain, why was this change not merged into Acme.sh ? |
@strausmann: Oh good question. I'm not sure what happened. I think it might have been user error on my part. I've resubmitted the patch: #6395 |
I have one suggestion for improvement. Restarting a local Plex service is a good idea. However, I use acme.sh on my Docker host and Plex in a container, so it would be good if you could customize the restart command using a variable, e.g. to “docker restart ”. |
@strausmann Good idea! I put my response over in the new pull request: #6395 (comment) |
Deploy script for use with a local Plex Media Server. Could help resolve Issues #3474, #3893, and #285