Skip to content

fix bug for #6510#6514

Merged
neilpang merged 1 commit intoacmesh-official:devfrom
zjwangmin:dev
Sep 27, 2025
Merged

fix bug for #6510#6514
neilpang merged 1 commit intoacmesh-official:devfrom
zjwangmin:dev

Conversation

@zjwangmin
Copy link

Fix bug for #6510
Fix the issue when the machine name is "a-b.c".

@github-actions
Copy link

Welcome
Please make sure you've read our Code-of-conduct and add the usage here: notify.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@zjwangmin
Copy link
Author

you can set hostname a-b.c
and then run:
acme.sh --set-notify --notify-hook telegram --debug
it's work.
image

@zjwangmin
Copy link
Author

Welcome Please make sure you've read our Code-of-conduct and add the usage here: notify. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

please review. many thanks.

@stanthewizzard
Copy link

with latest telegram.sh
https://github.com/acmesh-official/acme.sh
v3.1.2
[mar. 23 sept. 2025 12:10:16 CEST] Running cmd: setnotify
[mar. 23 sept. 2025 12:10:16 CEST] Using config home: /root/.acme.sh
[mar. 23 sept. 2025 12:10:16 CEST] default_acme_server
[mar. 23 sept. 2025 12:10:16 CEST] ACME_DIRECTORY='https://acme.zerossl.com/v2/DV90'
[mar. 23 sept. 2025 12:10:16 CEST] _ACME_SERVER_HOST='acme.zerossl.com'
[mar. 23 sept. 2025 12:10:16 CEST] _ACME_SERVER_PATH='v2/DV90'
[mar. 23 sept. 2025 12:10:16 CEST] Set notify hook to: telegram
[mar. 23 sept. 2025 12:10:16 CEST] Sending via: telegram
[mar. 23 sept. 2025 12:10:16 CEST] Found /root/.acme.sh/notify/telegram.sh for telegram
[mar. 23 sept. 2025 12:10:16 CEST] _statusCode='0'
sed: -e expression n°1, caractère 35: Fin d'intervalle invalide
sed: -e expression n°1, caractère 35: Fin d'intervalle invalide
[mar. 23 sept. 2025 12:10:16 CEST] _URGLY_PRINTF
[mar. 23 sept. 2025 12:10:16 CEST] xargs
[mar. 23 sept. 2025 12:10:16 CEST] {"text": "\n", "chat_id": "xxxxxxxxxxxxxxxx", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}
[mar. 23 sept. 2025 12:10:16 CEST] POST
[mar. 23 sept. 2025 12:10:16 CEST] _post_url='https://api.telegram.org/botxxxxxxxxxxxxxxxxxxxxxxxx/sendMessage'
[mar. 23 sept. 2025 12:10:16 CEST] body='{"text": "
\n", "chat_id": "443015641", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}'
[mar. 23 sept. 2025 12:10:16 CEST] _postContentType
[mar. 23 sept. 2025 12:10:16 CEST] _CURL='curl --silent --dump-header /root/.acme.sh/http.header -L --trace-ascii /tmp/tmp.5J90i2Rupu -g '
[mar. 23 sept. 2025 12:10:16 CEST] _ret='0'
[mar. 23 sept. 2025 12:10:16 CEST] telegram send error.
[mar. 23 sept. 2025 12:10:16 CEST] {"ok":false,"error_code":400,"description":"Bad Request: text must be non-empty"}
[mar. 23 sept. 2025 12:10:16 CEST] Error sending message using telegram_send
[mar. 23 sept. 2025 12:10:16 CEST] Error setting /root/.acme.sh/notify/telegram.sh.
[mar. 23 sept. 2025 12:10:16 CEST] Cannot set notify hook to: telegram

@neilpang neilpang merged commit f2dbf56 into acmesh-official:dev Sep 27, 2025
3 checks passed
@stanthewizzard
Copy link

tried it
Still doesnt't work

[dim. 28 sept. 2025 08:55:46 CEST] telegram send error.
[dim. 28 sept. 2025 08:55:46 CEST] {"ok":false,"error_code":400,"description":"Bad Request: text must be non-empty"}
[dim. 28 sept. 2025 08:55:46 CEST] Error sending message using telegram_send
[dim. 28 sept. 2025 08:55:46 CEST] Error setting /root/.acme.sh/notify/telegram.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants