QUIC.cloud DNS API support (dns_api.sh)#6631
Conversation
|
Welcome |
|
You MUST pass the DNS-API-Test. |
|
Hi, |
|
Now after 1 hour 45 minutes: ...and it passes so much first! Bob |
|
Can someone let me know if I'm wrong in believing that I've gone about as far in testing as I can go? Or is it expected that all tests will pass, each and every time if everything is right? Thanks! Bob |
|
Now it's failing in FreeBSD, but it passed there earlier. So much is passing and the reasons for failing don't seem like DNS API bugs to me... |
|
Run succeeded. |
|
I really think it's ready to be approved. The workflow succeeded. Is there something I still need to do? |
|
@adriangligor |
| dns_qc_add() { | ||
| fulldomain=$1 | ||
| txtvalue=$2 | ||
|
|
There was a problem hiding this comment.
check "if ! _exists jq " _err ""; and return 1
There was a problem hiding this comment.
@neilpang I'm a little confused. Do you want me to verify that fulldomain and/or txtvalue are not JSON? Or that the response is JSON (perhaps right before line 106?).
Thanks!
There was a problem hiding this comment.
@neilpang Thanks for the explanation. I've pushed the update
|
it's not passing. https://github.com/rperper/acme.sh/actions/runs/20462958239/job/58799751194 you need to change the dockerfile to add jq. |
|
@neilpang Removed jq requirement and it appears to pass all workflow test. Am I ok? Bob |
QUIC.cloud
This is support for acme.sh for the QUIC.cloud network.