Skip to content

Conversation

@pini-gh
Copy link

@pini-gh pini-gh commented Nov 24, 2025

Fixes #6081.

The LiveDNS authentication variables are now saved and retrieved using respectively _saveaccountconf_mutable and _readaccountconf_mutable functions.

This fixes an issue with tools such as nginx-proxy/acme-companion where authentication settings are done using environment variables only: new values for the authentication token were ignored and the saved one was used instead.

@github-actions
Copy link

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@Neilpang
Copy link
Member

it's easy to fix 6081.
just use _saveaccountconf_mutable instead of _saveaccountconf

And use _readaccountconf_mutable at the beginning .

@pini-gh
Copy link
Author

pini-gh commented Nov 24, 2025

Thank you, I wasn't aware of this _mutable flavor. I fixed the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants