Add support for TEST_DNS_TXT_LEN secret in DNS API workflow (for acmetest PR) #6641
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the DNS workflow to support the new
TEST_DNS_TXT_LENsecret introduced in acmetest PR.The related changes in the testing framework are implemented in my PR to acmetest:
acmetest PR: acmesh-official/acmetest#34
The updated acmetest adds the ability to configure the length of TXT values used during DNS API testing — a requirement for testing systems such as acme-dns, which expect TXT records with an exact length. To ensure acme.sh can pass this configuration to all test environments, the workflow needs to be updated accordingly.
What This PR Does
1. Adds support for the
TEST_DNS_TXT_LENsecretletest.shor the acmetest Docker runtime2. Updates Docker-based testing
TEST_DNS_TXT_LENtodocker.envso that the variable is available inside the acmetest container3. Updates VM-based testing (FreeBSD, OpenBSD, NetBSD, DragonFlyBSD, Solaris, OmniOS)
TEST_DNS_TXT_LENto theenvs:variable list so that the VM receives the configurationWhy This Change Is Needed
The updated acmetest now allows generating TXT values of a configurable size.
This is required because some DNS ACME challenge implementations — specifically acme-dns — need TXT records of a fixed length to function correctly.
Without updating the acme.sh workflow:
With this PR, the workflow fully supports the new functionality.
Backward Compatibility
TEST_DNS_TXT_LENis not defined, all workflows behave exactly as before.Summary
This PR ensures that acme.sh’s DNS testing workflow is compatible with the upcoming enhancements in acmetest by exposing the new
TEST_DNS_TXT_LENsecret to all supported test environments.It enables full and consistent testing of DNS providers that require fixed-length TXT values while preserving existing behavior for all others.