Skip to content

dns_dynv6: Allow challenge strings that contain "id"#6746

Merged
neilpang merged 3 commits intoacmesh-official:devfrom
d-kurz:dev
Jan 10, 2026
Merged

dns_dynv6: Allow challenge strings that contain "id"#6746
neilpang merged 3 commits intoacmesh-official:devfrom
d-kurz:dev

Conversation

@d-kurz
Copy link
Contributor

@d-kurz d-kurz commented Jan 10, 2026

See commit message of the "fix(dynv6)" commit for details

If the random dns challenge string happens to contain 'id',
the parsing method passed a broken, mingled mix of the
record's data and id field, instead of just the id. As a result,
deleting the TXT record failed. We now specifically look for
'"id":', which cannot appear as part of the challenge string.
@github-actions
Copy link

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@d-kurz
Copy link
Contributor Author

d-kurz commented Jan 10, 2026

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

PR against dev branch, API test finished successfully. We should be good 👍

@neilpang neilpang merged commit bc646d1 into acmesh-official:dev Jan 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants