Skip to content

Conversation

@OrigamiStarz
Copy link

@OrigamiStarz OrigamiStarz commented Nov 17, 2025

Info

Closes #14.

Changes

  • Adjust text styling in Hero (triangle) section, Room1 (What is DiamondHacks?) section, and Room3 (FAQ) section so that the text isn't popping outside of the containers
  • Adjust implementation of Room3 (FAQ) section
    • Fixed inconsistent spacing for outer/inner trapezoids
    • Also modified font weight + spacing

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
diamondhacks-2026 Ready Ready Preview Comment Nov 18, 2025 0:45am

Copy link
Collaborator

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me! I had a small change I wanted to fix the padding for the mobile for this part to look more consistent. After that, it should be good to merge in
Current:
Screenshot 2025-11-20 at 6 18 31 PM
Ideal:
Screenshot 2025-11-20 at 6 24 00 PM

<div>
<Link href="/sorting-quiz" className={styles.ctaButton}>
Take the Sorting Quiz
{/* <Arrow className={styles.arrow} /> */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the figma design had an arrow, so we should add that back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants