Open
Conversation
github-actions
bot
added
build
controller backend
controller mappings
code quality
labels
Pull Request Test Coverage Report for Build 14683616053Details
💛 - Coveralls |
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
2 times, most recently
from
558acd3 to
8051d37
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support
branch
from
139ae83 to
5bf3aa0
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
from
8051d37 to
760189b
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support
branch
from
5bf3aa0 to
f42250a
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
from
760189b to
183daad
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support
branch
from
f42250a to
8b726bc
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support
branch
2 times, most recently
from
1c75b6f to
c2c7272
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
from
183daad to
3a06e04
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
2 times, most recently
from
5e447e8 to
a9ff489
Compare
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
from
a9ff489 to
ac805d1
Compare
github-actions
bot
added
analyzer
effects
library
preferences
skins
soundio
ui
qml
engine
autodj
labels
- Change database schema from INTEGER to FLOAT for cents precision - Change protobuf tuning_frequency_hz from int32 to double - Remove is_432hz field from protobuf (redundant) - Remove is432Hz() methods from Keys and Track classes - Update all tuning frequency handling to use double - Use QStringLiteral for unicode symbols in keydelegate - Add 0.5 Hz tolerance for 432Hz detection - Remove k432HzRole, use only kTuningFrequencyRole Addresses feedback from PR mixxxdj#15729 review by @daschuer
Use \uXXXX notation instead of literal Unicode characters as per Mixxx coding guidelines for better portability.
- Remove redundant DB state checks Addresses feedback from PR mixxxdj#15729 review by @daschuer
acolombier
force-pushed
the
main
branch
2 times, most recently
from
8c93bf6 to
d22d1e0
Compare
added 5 commits
December 27, 2025 15:47
Fixes a compiler warning about implicit type conversion.
Use 0 as default for the pitch frequency in the database, to allow to identify those library entries that are using a default value, instead of the detected frequency.
We assume 10 cents to be the lower bound for an audible difference in key for humans.
Instead of showing some possibly wrong default frequency we show nothing. This is the same behavior we have for key detection.
We also give a more exact floating-point number in the tool-tip.
For example a mixed track might be made up of tracks using different tuning frequencies.
Qt provides capitalized headers that are intended to be used in client applications. This improves compatibility across QT versions
Don't user internal qt includes
feat(QML): add basic DnD Deck interface
Add A4 Pitch column (schema + UI label)
acolombier
force-pushed
the
feat/s4-mk3-screen-support-with-shared-data
branch
from
fef0c5f to
bae9b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.