-
Notifications
You must be signed in to change notification settings - Fork 1
chore: change to mdx #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would maybe move this into docs /reference under the hood the references will be copied to /docs inside of source which I believe should allow the components to be resolved. This will keep the source code clean where things that relate to docs are logically grouped together. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. /reference/components/**.* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import React from "react"; | ||
| import "./table.css"; | ||
|
|
||
| export default function StyledTable({ children }) { | ||
| return <div className="table-container"><table>{children}</table></div>; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| .table-container { | ||
| margin: 2em 0; | ||
| overflow-x: auto; | ||
| background: #fff; | ||
| border-radius: 8px; | ||
| box-shadow: 0 2px 8px rgba(0,0,0,0.04); | ||
| padding: 1em; | ||
| } | ||
|
|
||
| .table-container table { | ||
| width: 100%; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| .table-container th, .table-container td { | ||
| border: 1px solid #e0e0e0; | ||
| padding: 0.75em 1em; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .table-container th { | ||
| background: #f5f5f5; | ||
| font-weight: 600; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed originally that this was just a typo that caused the table to not render properly. Is there a bug, that causes the markdown to not render?
I only ask to know if the intent is to have a better looking table or if the intent is to avoid a rendering bug. Better looking table, which is all good as well, just wanted to confirm the md table render works, which might be easier to maintain or work as a guide for people committing to the repo in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and I was unable to make it render properly if there is a way you can please give it a shot