Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces CI workflows to ensure that client, enclave, and proxy can be natively built across {Ubuntu, macOS} × {x86_64, Aarch64} combinations. While verifying that enclave and proxy run on macOS is not strictly necessary, ensuring they compile is still valuable for development flexibility. Code quality is also enforced through
rustfmtandclippy.No changes to the main codebase; this PR only adds CI configuration files.
Background
AWS Nitro Enclaves can run on any Nitro Hypervisor-based EC2 instance regardless of CPU architecture (x86_64 or Aarch64). Therefore, the enclave and proxy should ideally be buildable on any CPU architecture.
Currently, manual testing is performed on 1st/2nd Gen Intel Xeon (x86_64) based EC2 instances (specifically Intel Xeon Platinum 8223CL (2nd Gen) according to
lscpu). Additionally, the client application should ideally run on any Arch/OS combination.What's changed
.github/workflows/lint.yml: Runscargo fmt --checkandcargo clippyonstabletoolchain to enforce code formatting and catch common issues.github/workflows/test.yml: Runscargo testacross a matrix of:Test
All CI check passed (green).