Skip to content

CLI-1435: PHP error - undefined array key handled in pull command #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danepowell merged 9 commits into from
Jan 23, 2025
Merged

CLI-1435: PHP error - undefined array key handled in pull command #1844

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7b933c8
PHP error : undefined array key handled
rahulgupta-acquia Jan 18, 2025
883b5bf
Merge branch 'main' into CLI-1435
danepowell Jan 21, 2025
87bb014
Fix test case:
rahulgupta-acquia Jan 21, 2025
e6814d2
Fix test case:
rahulgupta-acquia Jan 21, 2025
69674ca
fix the failure test case
rahulgupta-acquia Jan 21, 2025
7f2ccb0
fix the failure testcase
rahulgupta-acquia Jan 22, 2025
fcc3c79
Fix the failure test case
rahulgupta-acquia Jan 22, 2025
bea64ed
fix mutation test
rahulgupta-acquia Jan 22, 2025
81d261d
cleanup
danepowell Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Command/CommandBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,10 @@
foreach ($acsfSites['sites'] as $domain => $acsfSite) {
$choices[] = "{$acsfSite['name']} ($domain)";
}
if (!count($choices)) {
throw new AcquiaCliException("Could not get ACSF sites");

Check warning on line 1521 in src/Command/CommandBase.php

View check run for this annotation

Codecov / codecov/patch

src/Command/CommandBase.php#L1521 

Added line #L1521 was not covered by tests
Copy link
Contributor

@danepowell danepowell Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add a test case to cover this line. I'd suggest copying testRefreshAcsfFiles from PullFilesCommandTest.php and modify it to expect this exception. You'll need to modify mockGetAcsfSites() to return 0 sites to trigger the exception.

}

$choice = $this->io->choice('Choose a site', $choices, $choices[0]);
$key = array_search($choice, $choices, true);
$sites = array_values($acsfSites['sites']);
Expand Down
Loading