GL-3070: PHP 8.4 support for Code Studio.#1847
Closed
bemarlan wants to merge 1 commit intoacquia:mainfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
=========================================
Coverage 92.92% 92.92%
Complexity 1847 1847
=========================================
Files 123 123
Lines 6968 6969 +1
=========================================
+ Hits 6475 6476 +1
Misses 493 493 ☔ View full report in Codecov by Sentry. |
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1847/acli.phar |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
Author
|
Closing in favor of #1854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
Cloud does not yet support PHP 8.4 per PC-22704. This PR should wait to be merged & released until Cloud supports PHP 8.4.
Motivation
Addresses GL-3070
Proposed changes
Adds PHP 8.4 as a prompt option during the
cs:wizardcommand.Alternatives considered
N/A
Testing steps
glab auth login --hostname=code.dev.cloudservices.acquia.ioexport GITLAB_HOST=code.dev.cloudservices.acquia.io./bin/acli cs:wizardSelect a PHP version. Note 8.4 is now an option.