Skip to content

GL-3070: PHP 8.4 support for Code Studio.#1847

Closed
bemarlan wants to merge 1 commit intoacquia:mainfrom
bemarlan:GL-3070
Closed

GL-3070: PHP 8.4 support for Code Studio.#1847
bemarlan wants to merge 1 commit intoacquia:mainfrom
bemarlan:GL-3070

Conversation

@bemarlan
Copy link

DO NOT MERGE YET
Cloud does not yet support PHP 8.4 per PC-22704. This PR should wait to be merged & released until Cloud supports PHP 8.4.

Motivation

Addresses GL-3070

Proposed changes

Adds PHP 8.4 as a prompt option during the cs:wizard command.

Alternatives considered

N/A

Testing steps

  1. Locally, run glab auth login --hostname=code.dev.cloudservices.acquia.io
  2. Run export GITLAB_HOST=code.dev.cloudservices.acquia.io
  3. Run ./bin/acli cs:wizard
  4. Answer prompts until you see the prompt for Select a PHP version. Note 8.4 is now an option.
  5. Note: 8.3 is still the default selection per Out of Scope section in FR-2809
Screenshot 2025-01-30 at 11 09 54 AM

@bemarlan bemarlan marked this pull request as draft January 30, 2025 16:28
@bemarlan bemarlan changed the title [WIP] GL-3070: PHP 8.4 support for Code Studio. GL-3070: PHP 8.4 support for Code Studio. Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (e1c930e) to head (5cc2a2f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1847   +/-   ##
=========================================
  Coverage     92.92%   92.92%           
  Complexity     1847     1847           
=========================================
  Files           123      123           
  Lines          6968     6969    +1     
=========================================
+ Hits           6475     6476    +1     
  Misses          493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1847/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1847/acli.phar
chmod +x acli.phar

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@bemarlan bemarlan marked this pull request as ready for review March 3, 2025 13:22
@bemarlan
Copy link
Author

bemarlan commented Mar 5, 2025

Closing in favor of #1854

@bemarlan bemarlan closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant