Skip to content

GL-3133: Add prompt for NODE_HOSTING_TYPE.#1848

Merged
danepowell merged 4 commits intoacquia:mainfrom
bemarlan:GL-3133
Mar 20, 2025
Merged

GL-3133: Add prompt for NODE_HOSTING_TYPE.#1848
danepowell merged 4 commits intoacquia:mainfrom
bemarlan:GL-3133

Conversation

@bemarlan
Copy link

@bemarlan bemarlan commented Feb 7, 2025

Motivation

Addresses GL-3133

Proposed changes

If application type is selected as Node, adds a prompt to select the node hosting type in the cs:wizard command.

Alternatives considered

N/A

Testing steps

  1. Locally, run glab auth login --hostname=code.dev.cloudservices.acquia.io
  2. Run export GITLAB_HOST=code.dev.cloudservices.acquia.io
  3. Run ./bin/acli cs:wizard
  4. Answer prompts, ensuring to select an application type of node, until you see the prompt for node hosting type
    Screenshot 2025-02-07 at 1 12 42 PM

@bemarlan bemarlan marked this pull request as draft February 7, 2025 18:11
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (0f196c7) to head (d0af433).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1848   +/-   ##
=========================================
  Coverage     92.29%   92.29%           
  Complexity     1778     1778           
=========================================
  Files           121      121           
  Lines          6629     6635    +6     
=========================================
+ Hits           6118     6124    +6     
  Misses          511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 7, 2025

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1848/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1848/acli.phar
chmod +x acli.phar

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@bemarlan bemarlan marked this pull request as ready for review March 20, 2025 12:46
@bemarlan
Copy link
Author

Code Studio launched Node V3, so this PR is ready to merge.

@shriacquia shriacquia added enhancement php Pull requests that update Php code labels Mar 20, 2025
@danepowell danepowell merged commit de9f9a6 into acquia:main Mar 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants