Add vectorized file writes for improved I/O performance #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
changed the title
aliddell
force-pushed
the
with-vectorized-writing
branch
from
665d2bd to
4e33aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces platform-specific vectorized chunk writing to improve file I/O performance.
Key changes
Sink::write(size_t offset, const std::vector<uint8_t>& buffers)with implementations in child classes to write a collection of buffers, either vectorized or in sequenceSink::align_to_system_size(size_t)with implementations in child classes to align sizes to a system-dependent size (e.g., sector size)Platform-specific implementations
pwritev()WriteFileGatherand appropriate I/O flags