Skip to content

Polish public interface for dbkit (root) and dbrutil packages #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vasayxtx merged 2 commits into from
Feb 20, 2025
Merged

Polish public interface for dbkit (root) and dbrutil packages #11

vasayxtx merged 2 commits into from
Feb 20, 2025

Conversation

@vasayxtx
Copy link
Member

@vasayxtx vasayxtx commented Feb 20, 2025 •
edited
Loading

  • Receive interface instead of concrete struct in dbrutil.NewSlowQueryLogEventReceiver().
  • Rename MetricsCollectorOpts to PrometheusMetricsOpts for consistency.

@vasayxtx vasayxtx changed the title Receive interface instead of concrete struct in dbrutil.NewSlowQueryL… Receive interface instead of concrete struct in dbrutil.NewSlowQueryLogEventReceiver() Feb 20, 2025
@vasayxtx vasayxtx changed the title Receive interface instead of concrete struct in dbrutil.NewSlowQueryLogEventReceiver() Polish public interface for root and dbrutil packages Feb 20, 2025
@vasayxtx vasayxtx changed the title Polish public interface for root and dbrutil packages Polish public interface for dbkit (root) and dbrutil packages Feb 20, 2025
@vasayxtx vasayxtx merged commit dbc2e7b into acronis:main Feb 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeFalcon77 MikeFalcon77 Awaiting requested review from MikeFalcon77

1 more reviewer

@kaato137 kaato137 kaato137 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vasayxtx @kaato137