feat(HypercoreDepositHandler): Allow different types of messages passed to handleAcrossV3Message #1223
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to handleAcrossV3Message Read first byte to determine how to decode `message`: - type 1: message = abi.encode(user) - type 2: message = abi.encode(user, signature) type 2 messages can be used to activate new accounts, type 1 cannot
nicholaspai
added
the
need to audit
Contributor
|
@nicholaspai are we moving forward with sig-based account creation? As we discussed in Slack, this doesn't fully protect us from griefing, but makes griefing a bit harder |
Member
Author
Yes, because we want the griefing protection to be possible at the API level. With signatures we can control do this, whereas if we don't have signatures at all, then even the API can't protect against this. |
fusmanii
reviewed
Jan 8, 2026
Co-authored-by: Faisal Usmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read first byte to determine how to decode
message:type 2 messages can be used to activate new accounts, type 1 cannot