refactor: migrate tasks #1226
refactor: migrate tasks #1226
Conversation
Signed-off-by: Taylor Webb <[email protected]>
…onstrustor args) Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
grasphoper
left a comment
grasphoper
left a comment
There was a problem hiding this comment.
Left a few minor comments!
script/tasks/TestChainAdapter.s.sol
Outdated
| require(adapterAddress != address(0), string.concat("Adapter not found: ", adapterName)); | ||
|
|
||
| this.run(spokeChainId, adapterAddress, l1Token, amount, l2Token); | ||
| } |
There was a problem hiding this comment.
I suggest that we either add a usage example for this method, or remove it completely. I think at this point it's easier(less of a mental load heh) for a dev to manually insert "wanted adapter address" than to figure out how to call this other method (considering the example call is unavailable in the comments)
script/tasks/TestChainAdapter.s.sol
Outdated
| * forge script script/tasks/TestChainAdapter.s.sol:TestChainAdapter \ | ||
| * --sig "run(uint256,address,address,uint256,address)" \ | ||
| * 10 0x... 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48 1000000 0x... \ | ||
| * --rpc-url mainnet --broadcast |
There was a problem hiding this comment.
Mb include an example with real addrs? Or we can perhaps remove the second example as it's not materially different from Usage. Wdyt?
script/tasks/UpgradeSpokePool.s.sol
Outdated
| * Example: | ||
| * forge script script/tasks/UpgradeSpokePool.s.sol:UpgradeSpokePool \ | ||
| * --sig "run(address)" 0x1234567890123456789012345678901234567890 \ | ||
| * -vvvv |
There was a problem hiding this comment.
Are you sure we need both of these examples?
There was a problem hiding this comment.
This impl looks good to me. Have you checked against the old script to confirm that the outputs match? As we use this to generate multisig data (so it's sensitive)
There was a problem hiding this comment.
Yep! Outputs do match
Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
Signed-off-by: Taylor Webb <[email protected]>
Migrates
TestChainAdapterandUpdateSpokePooltasks to Foundry - these seem to be the only tasks that are currently used. Deletes old hardhat tasks and updates relevant documentation