Conversation
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
…e were reverting due to revert strings being stripped Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
This reverts commit 679640c.
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
… revert strings Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
27490a9 to
36ebd2e
Compare
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
d8802d4 to
1cbd2d2
Compare
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
…e readme Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
There was a problem hiding this comment.
2 comments on this:
- This
READMEseems very long and goes into a lot of details about the internals. Do you think we can make this shorter? Think about the dev. who's going to be deploying the system. They want a succinct README they can follow. Also, about the checklist after deployment. Unless that is exhaustive and 100% up-to-date, we shouldn't keep it. "Trust" in a file like this is very important for it to be used properly. We need to make sure it doesn't include details that are redundant / extra / 80% correct - Now that we have the SP1Helios contract and deployment script in the
contractsrepo, do you think it's possible to create a single script that will deploy the full Universal stack for a chain via a single command? Totally fine to do it in a follow-up. We might even complete that script with additional helper commands, like theupdate-vkeycommand that would generate a multisig multicall TX to send all of the admin acitons to the target universal spokes(just an idea, the single-deploy script is more important)
There was a problem hiding this comment.
- Yep totally agree, signficantly simplified the readme here: b5282de
- For sure, definitely should be possible. I'll build a script for this in a followup PR
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
grasphoper
left a comment
There was a problem hiding this comment.
LGTM. Let's hope no downstream repo relies on Helios naming 😄
Ideally all of them should be using UniversalSpokePool.helios() call to find the "true current helios" but you never know
This PR adds the SP1Helios contract, tests, and a Foundry deployment script. The deployment script downloads the appropriate genesis binary from our sp1-helios GitHub releases (detecting macOS vs Linux automatically), verifies the calculated binary checksum against checksums.json, and runs it to generate the initial light client configuration, and then deploys the SP1Helios contract with those parameters.
A new script/universal folder is added here that includes a readme on the full deployment process of SP1Helios & UniversalSpokePool to a new chain.
@bmzig @pxrl when you get a chance, please give a test run through the deployment process outlined in the new readme and lmk if there are any gaps in the described process.