Skip to content

chore: minor improvement for docs #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geogrego wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

chore: minor improvement for docs #2730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/finalizer/utils/opStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ async function getOVMStdEvents(
// that look exactly emit the same events as the standard bridge's ETH withdrawal process. This is used by the
// https://blast.io/en/bridge UI, so the following query allows this finalizer to finalize withdrawals of WETH
// from blast initiated through this hosted UI. ETH withdrawals sent in this manner through the Blast Bridge
// have the same ETHBridgeInitiated event signature so we only need to change the contract addres.
// have the same ETHBridgeInitiated event signature so we only need to change the contract address.
if (chainIsBlast(chainId)) {
const blastBridge = new Contract(CONTRACT_ADDRESSES[chainId].blastBridge.address, ovmStandardBridge.abi, provider);
const blastEthEvents = (
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/validateRunningBalances.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// indicating an amount of tokens that need to be taken out of the spoke pool to execute those slow fills
// - relayer_refund_t_c_i is the total amount of token t that needs to be refunded to relayers on chain c at block b
// which also indicates an amount of tokens that need to be taken out of the spoke pool to execute those refunds
// - excess_t_c_{i,i+1,i+2,...} should therefore be consistent unless tokens are dropped onto the spoke pool.
// - excess_t_c_{i,i+1,i+2,...} should therefore be consistent unless tokens are dropped onto the spoke pool.

// This script also can be used to identify any unexecuted leaves in the last N bundles, where N is configurable.
// If there are any, this script will log the leaf + proof conveniently for manual execution.
Expand Down
10 changes: 5 additions & 5 deletions test/generic-adapters/AdapterManager.SendTokensCrossChain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe("AdapterManager: Send tokens cross-chain", async function () {
const chainId = CHAIN_IDs.OPTIMISM;
const l2Gas = 200000; // This is hardcoded in all OVM Bridges

// ERC20 tokens:
// ERC20 tokens:
await adapterManager.sendTokenCrossChain(
toAddressType(relayer.address, CHAIN_IDs.MAINNET),
chainId,
Expand Down Expand Up @@ -186,7 +186,7 @@ describe("AdapterManager: Send tokens cross-chain", async function () {
it("Correctly sends tokens to chain: Polygon", async function () {
const chainId = CHAIN_IDs.POLYGON;

// ERC20 tokens:
// ERC20 tokens:
await adapterManager.sendTokenCrossChain(
toAddressType(relayer.address, CHAIN_IDs.MAINNET),
chainId,
Expand Down Expand Up @@ -237,7 +237,7 @@ describe("AdapterManager: Send tokens cross-chain", async function () {
const l2GasLimit = toBN(150000);
const l2GasPrice = toBN(20e9);

// ERC20 tokens:
// ERC20 tokens:
await adapterManager.sendTokenCrossChain(
toAddressType(relayer.address, CHAIN_IDs.MAINNET),
chainId,
Expand Down Expand Up @@ -295,7 +295,7 @@ describe("AdapterManager: Send tokens cross-chain", async function () {
secondBridgeAddress: CONTRACT_ADDRESSES[CHAIN_IDs.MAINNET].zkStackSharedBridge.address, // Shared bridge address
secondBridgeValue: bnZero,
};
// ERC20 tokens:
// ERC20 tokens:
await adapterManager.sendTokenCrossChain(
toAddressType(relayer.address, CHAIN_IDs.MAINNET),
chainId,
Expand Down Expand Up @@ -360,7 +360,7 @@ describe("AdapterManager: Send tokens cross-chain", async function () {
const chainId = CHAIN_IDs.BASE;
const l2Gas = 200000; // This is hardcoded in all OVM Bridges

// ERC20 tokens:
// ERC20 tokens:
await adapterManager.sendTokenCrossChain(
toAddressType(relayer.address, CHAIN_IDs.MAINNET),
chainId,
Expand Down