improve(finalizer): Flush out chain-specific override tech debt#3031
Merged
improve(finalizer): Flush out chain-specific override tech debt#3031
Conversation
Viem's extractChain() is wrapped to provide some type assurances around chainId, because Chain.id is typed as a union of known chainIds, whereas the relayer's chainId is always a number type. This change is useful for a follow-up change to simplify the handling of viem chains in the finalizer.
This change migrates chain-specific supplements for DisputeGameFactory to a viem patch in anticipation of these changes being accepted upstream. This in turn permits some of the viem overrides to be wound back, and reduces the maintenance burden of viem vs pre-viem OP stack SDK support.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
pxrl
commented
Mar 10, 2026
bmzig
previously approved these changes
Mar 10, 2026
nicholaspai
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change migrates chain-specific supplements for DisputeGameFactory to a viem patch in anticipation of these changes being accepted upstream. This in turn permits some of the viem overrides to be wound back, and reduces the maintenance burden of viem vs pre-viem OP stack SDK support.