refactor(Monitor): Tiny cleanup for CrossChainTransferClient split#3038
Open
refactor(Monitor): Tiny cleanup for CrossChainTransferClient split#3038
Conversation
It seems like the CrossChainClient can be split into two instances within the Monitor in order to ease rebalance tracking complexities that have been pushed down into the bridge adapter layer. Do some simple reshuffling in advance of that, whilst additionally dereferencing a few this.clients instances directly.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the CrossChainClient can be split into two instances
within the Monitor in order to ease rebalance tracking complexities that
have been pushed down into the bridge adapter layer. Do some simple
reshuffling in advance of that, whilst additionally dereferencing a few
this.clients instances directly.